Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darts: link to explanations for math lingo #1976

Merged
merged 2 commits into from
Apr 9, 2022
Merged

Conversation

SaschaMann
Copy link
Contributor

see also #1971 even if this change doesn't resolve the issue.

see also #1971 even if this change doesn't resolve the issue.
Copy link
Member

@petertseng petertseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is certainly an improvement, so I think that is reason to Approve. I do wonder however if it is not easy to tell that there are two separate links right next to each other. I am not sure how to solve this problem. The way that comes to my mind first is rewording it, such as "defined by its x and y cartesian coordinates, both of which are real numbers". However, I am not sure if that rewording is awkward, so I have not yet decided to put forth that suggestion.

@SaschaMann
Copy link
Contributor Author

this is certainly an improvement, so I think that is reason to Approve. I do wonder however if it is not easy to tell that there are two separate links right next to each other.

I was wondering the same. I'm not sure.

Another solution would be a small icon that indicates it's a link to an external website.

@ErikSchierboom
Copy link
Member

I agree with the usefulness of visually separating the two links somehow.

Maybe:

"defined by its x and y cartesian coordinates (which are both real numbers)"

@SaschaMann
Copy link
Contributor Author

@exercism/reviewers

@@ -14,4 +14,4 @@ In our particular instance of the game, the target rewards with 4 different amou

The outer circle has a radius of 10 units (This is equivalent to the total radius for the entire target), the middle circle a radius of 5 units, and the inner circle a radius of 1. Of course, they are all centered to the same point (That is, the circles are [concentric](http://mathworld.wolfram.com/ConcentricCircles.html)) defined by the coordinates (0, 0).

Write a function that given a point in the target (defined by its `real` cartesian coordinates `x` and `y`), returns the correct amount earned by a dart landing in that point.
Write a function that given a point in the target (defined by its [cartesian coordinates](https://www.mathsisfun.com/data/cartesian-coordinates.html) `x` and `y`, where `x` and `y` are [real](https://www.mathsisfun.com/numbers/real-numbers.html)), returns the correct amount earned by a dart landing in that point.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Write a function that given a point in the target (defined by its [cartesian coordinates](https://www.mathsisfun.com/data/cartesian-coordinates.html) `x` and `y`, where `x` and `y` are [real](https://www.mathsisfun.com/numbers/real-numbers.html)), returns the correct amount earned by a dart landing in that point.
Write a function that given a point in the target (defined by its [cartesian coordinates] `x` and `y`, where `x` and `y` are [real numbers]), returns the correct amount earned by a dart landing in that point.
[cartesian coordinates]: https://www.mathsisfun.com/data/cartesian-coordinates.html
[real numbers]: (https://www.mathsisfun.com/numbers/real-numbers.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants