-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darts]: Mention what should happen when a dart lands 'on the line' #3163
Comments
This comment was marked as resolved.
This comment was marked as resolved.
I think the |
A question more about the philosophy of these exercises: should we consider reading the tests as part of the exercise, or should one be able to successfully complete the exercise without ever reading the tests? |
See https://exercism.org/docs/tracks/python/test-driven-development where the track explicitly discusses this issue.
The test is the definitive embodied exercise requirement. The prose simply provides an overview and context. |
Good point. I'll close the issue. |
@KaiAragaki - I am going to reopen this issue, as I intended to have a discussion, but was delayed by other work. I'll chime in with more thoughts @IsaacG - while you are technically correct, I think we should always consider suggestions from students - especially those new to the track when they say something needs to be clarified in the instructions or hints. Yes - we do indeed practice TDD, but that doesn't mean that because there are tests that instructions are frozen in stone, or that something can't be more detailed or amended. Please don't imply to students that that is the case unless we have a discussion first. It's likely that I and other maintainers of the track will agree with you - but some exercises have a history of issues or approaches that you might not know. This exercise has already had a |
@KaiAragaki - Because this is a practice exercise, we have less leeway (actually, more complication) in editing problem instructions and tests. We pull both descriptions and test specification from the problem-specificaions repo using a tool called configlet. Test data is then run through a generator script to produce the Python test files. Problem descriptions are mostly taken as-is, or amended via Changes to the main descriptions/instructions and test data are proposed/discussed cross-language track in problem-specifications. We try to keep both fairly generic and language agnostic. Once three or more track maintainers agree that a change is needed, it is PR'd there and then pulled down into various tracks. Tests and instructions that are language specific are then added via
So let me know what you'd like to do. 😄 |
@KaiAragaki -- 🤔 I .. somehow didn't track that Sascha made adjustments to the description text already. Maybe in that case we both close # 1791, and open a new issue in problem-specs with your recommendations? Unless you think they'd be better as a Python-only addendum. Does that make sense? |
This issue has been automatically marked as |
Closing stale issue. If this issue is still relevant, please reopen it. |
Though it's implied in the tests, it might be nice to include that if a dart lands on the border between one ring and the other (say it lands at 0, 5) that it should go to the higher values. If this is acceptable, I can make a PR to update the exercise.
The text was updated successfully, but these errors were encountered: