Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper module info #41

Closed
wants to merge 2 commits into from
Closed

proper module info #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7872f1
proper module info
lsc-mambu Feb 11, 2025
488dcde
updates for tests
lsc-mambu Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*-
* #%L
* Internet Time Utility
* %%
* Copyright (C) 2017 - 2025 Morten Haraldsen @ethlo
* %%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* #L%
*/
module com.ethlo.itu {
exports com.ethlo.time;
exports com.ethlo.time.token;

requires static java.desktop;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be needed? This library has zero UI interaction.

Copy link
Author

@lscoughlin lscoughlin Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an optional/invisible dependency based on a class you use in a test case.

Folks that depend on your library must also depend on every library you depend on, unless it's 'static' which is admittedly weirdly overriden to mean optional for modules.

}