Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proper module info #41

Closed
wants to merge 2 commits into from
Closed

proper module info #41

wants to merge 2 commits into from

Conversation

lscoughlin
Copy link

addresses issue #40

exports com.ethlo.time;
exports com.ethlo.time.token;

requires static java.desktop;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would this be needed? This library has zero UI interaction.

Copy link
Author

@lscoughlin lscoughlin Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an optional/invisible dependency based on a class you use in a test case.

Folks that depend on your library must also depend on every library you depend on, unless it's 'static' which is admittedly weirdly overriden to mean optional for modules.

@ethlo
Copy link
Owner

ethlo commented Feb 12, 2025

Closing this in favor of #42. Thank you.

@ethlo ethlo closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants