Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isthmus): l2tol1 message passer storage root #3

Closed
wants to merge 96 commits into from
Closed

feat(isthmus): l2tol1 message passer storage root #3

wants to merge 96 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Dec 13, 2024 •
edited
Loading

Description

Closes #4

Block building
  • Skips committing Shanghai withdrawals, instead debug asserts withdrawals in block body is empty.
  • Computes the storage root of l2tol1-message-passer contract in block building, and writes to withdrawals root field of block.
Block validation in live-sync
  • Decouples checking empty withdrawals list from checking empty withdrawals root - only checks empty withdrawals root if isthmus is not active.
  • Adds access to database to previously stateless block consensus validation. Checks withdrawals root of block (aka l2tol1-msg-passer storage root) against loaded storage root of the predeploy.
Block validation in pipeline-sync

Tests

Additional context

Metadata

@emhane emhane added the B-isthmus-devnet-0 Related to isthmus-devnet-0 label Dec 13, 2024
joshieDo and others added 26 commits December 13, 2024 14:02
@joshieDo @emhane
chore: add OmmersProvider trait (paradigmxyz#13331)
ef59082
@TropicalDog17 @emhane
feat(blockchain-tree-api): remove manual implementations of core::err…
2d7bce3 
…or::Error (paradigmxyz#13332)
@htiennv @emhane
feat(reth-execution-types): make generic DisplayBlocksChain (paradigm…
106d1b1 
…xyz#13336)
@mattsse @emhane
chore: impl evm env provider for noop (paradigmxyz#13342)
930f84f
@mattsse @emhane
chore: move secp256 crypto to primitive-traits (paradigmxyz#13341)
374d9fa
@mattsse @emhane
chore: relax eth pooled tx (paradigmxyz#13271)
85cc27b
@tnv1 @emhane
feat: make BuiltPayload generic (paradigmxyz#13337)
0fd89ca
@mvares @mattsse @emhane
feat(rpc): remove total difficulty (paradigmxyz#13303)
02f7643 
Co-authored-by: Matthias Seitz <[email protected]>
@mattsse @emhane
chore: unify noop provider impls (paradigmxyz#13345)
5d365cf
@vcastellm @emhane
docs: inline mermaid diagrams while aquamarine is fixed (paradigmxyz#…
f538268 
…13302)
@fgimenez @emhane
feat(trie): replace TrieInput by its components in ParallelProof (par…
d342abd 
…adigmxyz#13346)
@TheDhejavu @emhane
chore: update gas limit on new head block (paradigmxyz#13333)
f3e7590
@klkvr @emhane
feat: optimism-specific receipt (paradigmxyz#13317)
956ef89 
Co-authored-by: Emilia Hane <[email protected]>
@joshieDo @emhane
chore: add BlockBodyIndicesProvider trait (paradigmxyz#13347)
b049982
@klkvr @emhane
chore: use OpTypedTransaction directly (paradigmxyz#13350)
c144ebc
@mattsse @emhane
chore: rm reth-provider dep from payload crate (paradigmxyz#13348)
a4ff9c6
@fgimenez @emhane
fix(engine): return error on StateRootTask multiproof and root calcul…
591a308 
…ation failures (paradigmxyz#13356)
@shekhirin @emhane
perf(engine): cache proof targets in proof sequencer for state root t…
f5ba6d3 
…ask (paradigmxyz#13310)
@rkrasiuk @emhane
fix(builder): desired block gas limit (paradigmxyz#13351)
6e3433b
@mattsse @emhane
feat: relax maintain (paradigmxyz#13349)
7b2163f
@mattsse @emhane
chore: rm redundant return (paradigmxyz#13361)
161a3e7
@mattsse @emhane
chore: relax some op pool validator internals (paradigmxyz#13358)
b3d26c4
@rkrasiuk @mattsse @emhane
chore(builder): remove extra data from basic payload generator (parad…
364a694 
…igmxyz#13353)

Co-authored-by: Matthias Seitz <[email protected]>
@klkvr @emhane
chore: move all secp256k1 helpers to primitives-traits (paradigmxyz…
ac432d5 
…#13363)
@mattsse @emhane
chore: update holocene fns (paradigmxyz#13366)
8632fc1
@mattsse @emhane
docs: document fork_id behaviour (paradigmxyz#13367)
8b64595
@emhane emhane force-pushed the emhane/storage-root-isthmus branch from e9894cb to 673ae2e Compare December 19, 2024 02:58
emhane added 16 commits December 19, 2024 04:11
@emhane
Enable reth-trie/test-utils in reth-optimism-consensus
62393a8
@emhane
Skip wasm check for reth-optimism-consensus, depends on std::time::Sy…
7df8a5e 
…stemTime
@emhane
Skip wasm check for reth-optimism-evm, depends on reth-optimism-conse…
70e7177 
…nsus (also on main)
@emhane
Fix bug, unit success skip ef-tests
1dbecaa
@emhane
Merge branch 'isthmus-devnet-0' into emhane/storage-root-isthmus
3f58f5a
@emhane
Enable kurtosis-op and hive for op-reth repo
555b164
@emhane
Merge pull request #10 from ethereum-optimism/emhane/kurtosis-op
de481d6 
Enable kurtosis-op and hive for op-reth repo
@emhane
Replace cron jobs for kurtosis-op and hive with push to noop branch
cb3fc23
@emhane
Merge pull request #11 from ethereum-optimism/emhane/rm-cron-job-checks
3d6c129 
Remove cron job checks
@emhane
Skip non-op kurtosis jobs complete
f9bfd14
@emhane
Merge pull request #12 from ethereum-optimism/emhane/skip-prepare-ret…
18e1fbb 
…h-kurtosis

Fix, skip non-op kurtosis jobs
@emhane
Merge branch 'isthmus-devnet-0' into emhane/storage-root-isthmus
0941367
@emhane
Merge branch 'optimism' into isthmus-devnet-0
64c4e56
@emhane
Merge branch 'isthmus-devnet-0' into emhane/storage-root-isthmus
0eb766a
@emhane
Revert disable manual workflow run for kurtosis-op and hive (#13)
80d6114 
<!--
Contributions welcome! See
https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md
-->

**Description**

Revert rm `workflow_dispatch` for kurtosis-op and hive

**Tests**

<!--
Please describe any tests you've added. If you've added no tests, or
left important behavior untested, please explain why not.
-->

**Additional context**

<!--
Add any other context about the problem you're solving.
-->

**Metadata**

<!-- 
Include a link to any github issues that this may close in the following
form:
- Fixes #[Link to Issue]
-->
@emhane
Merge branch 'isthmus-devnet-0' into emhane/storage-root-isthmus
b4151f8
@emhane emhane mentioned this pull request Jan 3, 2025
Open
@emhane
Copy link
Member Author

emhane commented Jan 3, 2025

closing in favour of #19

@emhane emhane closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdamle vdamle Awaiting requested review from vdamle

Assignees
No one assigned
Labels
B-isthmus-devnet-0 Related to isthmus-devnet-0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.