Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isthmus): verify storage root in execution #19

Open
wants to merge 19 commits into
base: isthmus-devnet-0
Choose a base branch
from

Conversation

emhane
Copy link
Member

@emhane emhane commented Jan 3, 2025

Closes #4, #5

Supersedes #3

Partially upstreamed in paradigmxyz#13538

Moves isthmus storage root verification into execution, instead of after execution. This way storage root verification can happen for batch executed blocks in pipeline sync, as well as in live sync. Furthermore it requires less changes to reth's and op-reth's shared type system.

<!--
Contributions welcome! See
https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md
-->

**Description**

Merges down and cleans up changes to ci from isthmus-devnet-0 branch.
Ref #8.

- Removes jobs: for L1, for deploying, some maintenance jobs
- Removes cron jobs

**Tests**

<!--
Please describe any tests you've added. If you've added no tests, or
left important behavior untested, please explain why not.
-->

**Additional context**

<!--
Add any other context about the problem you're solving.
-->

**Metadata**

<!-- 
Include a link to any github issues that this may close in the following
form:
- Fixes #[Link to Issue]
-->
@emhane emhane added B-isthmus-devnet-0 Related to isthmus-devnet-0 A-consensus Related to consensus engine A-execution Related to execution and EVM labels Jan 3, 2025
emhane added 4 commits January 4, 2025 00:36
<!--
Contributions welcome! See
https://github.com/ethereum-optimism/.github/blob/master/CONTRIBUTING.md
-->

**Description**

Adds back hive assets reused in workflow `kurtosis-op`.

**Tests**

<!--
Please describe any tests you've added. If you've added no tests, or
left important behavior untested, please explain why not.
-->

**Additional context**


https://github.com/ethereum-optimism/op-reth/actions/runs/12640451509/job/35220890751

**Metadata**

<!-- 
Include a link to any github issues that this may close in the following
form:
- Fixes #[Link to Issue]
-->
@emhane
Copy link
Member Author

emhane commented Jan 7, 2025

emhane added a commit that referenced this pull request Jan 7, 2025
…ing] (#23)

Commit PR, currently in review to upstream, to `isthmus-devnet-0`, to
make isthmus logic in
#19 review-friendly

Ref #16 (couldn't
re-open pr after force push)
@emhane emhane requested review from clabby and refcell January 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to consensus engine A-execution Related to execution and EVM B-isthmus-devnet-0 Related to isthmus-devnet-0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant