Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlx90614] pec validation #6689

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

asergunov
Copy link
Contributor

@asergunov asergunov commented May 7, 2024

What does this implement/fix?

Part of #6683 without i2c recovery.

mlx90614 fix stuck values

  • Uses POC (CRC) to make sure reading from sensor is correct
  • Pots NAN if i2c communication failed or POC invalid to prevent stuck values
  • Sets emissivity in update() if it's changed by set_emissivity call

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

Before:

before

After

after

sensor:
- platform: mlx90614
  id: furnace_temperature
  update_interval: 5s
  ambient:
    name: Ambient temperature
    id: furnace_ambient_temperature
  object:
    name: Furnace temperature
    id: furnace_object_temperature
    emissivity: 0.93

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

* Check PEC (CRC) reading registers
* Optional read reties. Defaults to 2
* Write emissivity back to device if changed
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (4d8b5ed) to head (588bcf6).
Report is 521 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6689      +/-   ##
==========================================
+ Coverage   53.70%   54.15%   +0.44%     
==========================================
  Files          50       50              
  Lines        9408     9574     +166     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5185     +132     
- Misses       4056     4065       +9     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asergunov asergunov marked this pull request as ready for review May 7, 2024 05:10
@asergunov asergunov requested a review from jesserockz as a code owner May 7, 2024 05:10
@probot-esphome
Copy link

probot-esphome bot commented May 7, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (mlx90614) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@asergunov asergunov marked this pull request as draft May 7, 2024 05:37
@asergunov asergunov marked this pull request as ready for review May 7, 2024 05:44
@asergunov
Copy link
Contributor Author

@jesserockz could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants