New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mlx90614] Fix frozen values in case of i2c communication error #6683
base: dev
Are you sure you want to change the base?
Conversation
* Check PEC reading values
Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6683 +/- ##
==========================================
+ Coverage 53.70% 54.15% +0.44%
==========================================
Files 50 50
Lines 9408 9574 +166
Branches 1654 1687 +33
==========================================
+ Hits 5053 5185 +132
- Misses 4056 4065 +9
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
Hey there @andreashergert1984, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the i2c recovery and the specific component changes into their own PRs.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Jesse Hills <[email protected]>
* Check PEC (CRC) reading registers * Optional read reties. Defaults to 2 * Write emissivity back to device if changed
|
What does this implement/fix?
Contains #6689
mlx90614 fix stuck values
i2c recover
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: