Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mlx90614] Fix frozen values in case of i2c communication error #6683

Draft
wants to merge 48 commits into
base: dev
Choose a base branch
from

Conversation

asergunov
Copy link
Contributor

@asergunov asergunov commented May 6, 2024

What does this implement/fix?

Contains #6689

mlx90614 fix stuck values

  • Recovers the i2c connection if sensor is not answering

i2c recover

  • Adds i2c recover routine to be called from bus interface
  • Implemented for Arduino and esp-idf
    • Deactivates i2c driver
    • Performs recover sequence
    • Activates i2c driver back

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

sensor:
- platform: mlx90614
  id: furnace_temperature
  update_interval: 5s
  ambient:
    name: Ambient temperature
    id: furnace_ambient_temperature
    entity_category: "diagnostic"
    filters:
      - delta: 
          value: 0.05
  object:
    name: Furnace temperature
    id: furnace_object_temperature
    emissivity: 0.93
    filters:
      - delta: 
          value: 0.05

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@asergunov asergunov requested a review from jesserockz as a code owner May 6, 2024 14:00
@probot-esphome
Copy link

probot-esphome bot commented May 6, 2024

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (mlx90614) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

probot-esphome bot commented May 6, 2024

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (i2c) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@asergunov asergunov changed the title Mlx90614 fix [mlx90614] Fix frozen values in case of i2c communication error May 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (4d8b5ed) to head (c49208f).
Report is 521 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6683      +/-   ##
==========================================
+ Coverage   53.70%   54.15%   +0.44%     
==========================================
  Files          50       50              
  Lines        9408     9574     +166     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5185     +132     
- Misses       4056     4065       +9     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome
Copy link

probot-esphome bot commented May 6, 2024

Hey there @andreashergert1984, mind taking a look at this pull request as it has been labeled with an integration (tca9548a) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the i2c recovery and the specific component changes into their own PRs.

esphome/components/tca9548a/tca9548a.cpp Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft May 7, 2024 00:45
@esphome
Copy link

esphome bot commented May 7, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

asergunov and others added 3 commits May 7, 2024 07:33
* Check PEC (CRC) reading registers
* Optional read reties. Defaults to 2
* Write emissivity back to device if changed
@asergunov asergunov mentioned this pull request May 7, 2024
13 tasks
@asergunov
Copy link
Contributor Author

Please split the i2c recovery and the specific component changes into their own PRs.

#6689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants