Skip to content

fix: playground crash due to ts parser #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

fix: playground crash due to ts parser #747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f765688
fix: playground crash due to ts parser
Tanujkanti4441 Jul 26, 2025
958f597
remove the parser update logic for default options
Tanujkanti4441 Jul 27, 2025
ccc7e5c
remove the function to check parser object
Tanujkanti4441 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/playground/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@ const fillOptionsDefaults = options => ({
...options,
languageOptions: {
...options.languageOptions,
...(options?.languageOptions?.parser ===
"@typescript-eslint/parser" && {
parser: typeScriptESLintParser,
}),
parserOptions: {
ecmaFeatures: {},
...options.languageOptions?.parserOptions,
Expand Down
23 changes: 3 additions & 20 deletions src/playground/components/Configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,18 +108,6 @@ const defaultOption = {

const isEmpty = obj => Object.keys(obj).length === 0;

const parserValue = parser => {
if (
(typeof parser === "object" &&
parser.meta.name === "typescript-eslint/parser") ||
parser === "@typescript-eslint/parser"
) {
return "@typescript-eslint/parser";
}

return null;
};

export default function Configuration({
initialOptions,
rulesMeta,
Expand Down Expand Up @@ -260,11 +248,7 @@ export default function Configuration({
if (config.languageOptions && config.languageOptions.parser) {
const parser = config.languageOptions.parser;

if (
parser === "@typescript-eslint/parser" ||
(typeof parser === "object" &&
parser?.meta?.name === "typescript-eslint/parser")
) {
if (parser === "@typescript-eslint/parser") {
config.languageOptions.parser = "___TS_PARSER_PLACEHOLDER___";
}
}
Expand Down Expand Up @@ -493,9 +477,8 @@ export default function Configuration({
value={ESLintParserOptions.filter(
eslintParser =>
eslintParser.value ===
(parserValue(
options.languageOptions?.parser,
) || "default"),
(options.languageOptions?.parser ||
"default"),
)}
options={ESLintParserOptions}
onChange={selected => {
Expand Down