fix: playground crash due to ts parser #747

Tanujkanti4441 · 2025-07-26T17:05:13Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Right now playground crashes because after a change in text or options the parser key in URL or LocalStorage sets to typeScriptESLintParser meta object rather than "@typescript-eslint/parser" string.

Steps to reproduce.

1 - Open Playground and set the parser to @typescript-eslint/parser.

2 - Change something in the text editor, like a space or anything.

3 - Then refresh the page.

https://eslint.org/play/#eyJ0ZXh0IjoiY29uc3QgZm9vID0gMTA7XG5cblxuIiwib3B0aW9ucyI6eyJydWxlcyI6e30sImxhbmd1YWdlT3B0aW9ucyI6eyJwYXJzZXJPcHRpb25zIjp7ImVjbWFGZWF0dXJlcyI6eyJqc3giOnRydWV9LCJzb3VyY2VUeXBlIjoibW9kdWxlIn0sInBhcnNlciI6eyJ2ZXJzaW9uIjoiOC4yOC4wIiwibWV0YSI6eyJuYW1lIjoidHlwZXNjcmlwdC1lc2xpbnQvcGFyc2VyIiwidmVyc2lvbiI6IjguMjguMCJ9fX19fQ==

What changes did you make? (Give an overview)

Added a condition in storeState function, if paser is typeScriptESLintParser meta object then make is parser = "@typescript-eslint/parser".

Related Issues

Is there anything you'd like reviewers to focus on?

netlify · 2025-07-26T17:05:18Z

✅ Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/new-eslint/deploys/6891b661c4170f00096fbfc2
😎 Deploy Preview	https://deploy-preview-747--new-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:05:18Z

✅ Deploy Preview for es-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/es-eslint/deploys/6891b6615b90b70008d5e9f0
😎 Deploy Preview	https://deploy-preview-747--es-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:05:18Z

✅ Deploy Preview for zh-hans-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/zh-hans-eslint/deploys/6891b661ddc6e30008cc1949
😎 Deploy Preview	https://deploy-preview-747--zh-hans-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:07:55Z

✅ Deploy Preview for fr-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/fr-eslint/deploys/6891b661a6a1450008fd6706
😎 Deploy Preview	https://deploy-preview-747--fr-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:08:08Z

✅ Deploy Preview for pt-br-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/pt-br-eslint/deploys/6891b6612ee7240008ba772e
😎 Deploy Preview	https://deploy-preview-747--pt-br-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:09:27Z

✅ Deploy Preview for ja-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/ja-eslint/deploys/6891b66105cdd600082e6a33
😎 Deploy Preview	https://deploy-preview-747--ja-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:09:54Z

✅ Deploy Preview for de-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/de-eslint/deploys/6891b661852125000850c7ce
😎 Deploy Preview	https://deploy-preview-747--de-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-07-26T17:10:51Z

✅ Deploy Preview for hi-eslint ready!

Name	Link
🔨 Latest commit	`ccc7e5c`
🔍 Latest deploy log	https://app.netlify.com/projects/hi-eslint/deploys/6891b66129d4150008f0c05f
😎 Deploy Preview	https://deploy-preview-747--hi-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

mdjermanovic

Would it be easier to use typeScriptESLintParser only in optionsForLinter, and "@typescript-eslint/parser" everywhere else? I.e., remove this:

eslint.org/src/playground/App.js

Lines 51 to 54 in d531e46

    
           ...(options?.languageOptions?.parser === 
        
           	"@typescript-eslint/parser" && { 
        
           	parser: typeScriptESLintParser, 
        
           }),

mdjermanovic · 2025-07-27T09:34:51Z

Steps to reproduce.

1 - Open Playground and set the parser to @typescript-eslint/parser.

2 - Change something in the text editor, like a space or anything.

3 - Then refresh the page.

It doesn't reproduce for me with these steps, but does reproduce with the following:

1 - Open Playground and set the parser to @typescript-eslint/parser.

2 - Then refresh the page.

3 - Change something in the text editor, like a space or anything.

4 - Then refresh the page again.

mdjermanovic · 2025-07-28T13:18:14Z

I think the checks if parser is a typescript-eslint parser object are unnecessary now:

eslint.org/src/playground/components/Configuration.js

Lines 111 to 121 in 53ce7ec

    
           const parserValue = parser => { 
        
           	if ( 
        
           		(typeof parser === "object" && 
        
           			parser.meta.name === "typescript-eslint/parser") || 
        
           		parser === "@typescript-eslint/parser" 
        
           	) { 
        
           		return "@typescript-eslint/parser"; 
        
           	} 
        
           	return null; 
        
           };

eslint.org/src/playground/components/Configuration.js

Lines 265 to 266 in 53ce7ec

    
           (typeof parser === "object" && 
        
           	parser?.meta?.name === "typescript-eslint/parser")

mdjermanovic

LGTM, thanks! Would like @snitin315 to verify before merging.

harish-sethuraman

LGTM

nzakas · 2025-08-06T14:35:14Z

Ping @snitin315

fix: playground crash due to ts parser

f765688

github-project-automation bot added this to Triage Jul 26, 2025

github-project-automation bot moved this to Needs Triage in Triage Jul 26, 2025

eslint-github-bot bot added the bug Something isn't working label Jul 26, 2025

Tanujkanti4441 mentioned this pull request Jul 26, 2025

docs: playground button for TypeScript code example eslint/eslint#19671

Merged

1 task

mdjermanovic reviewed Jul 27, 2025

View reviewed changes

mdjermanovic moved this from Needs Triage to Implementing in Triage Jul 27, 2025

mdjermanovic added accepted repro:yes Issues with a reproducible example labels Jul 27, 2025

remove the parser update logic for default options

958f597

remove the function to check parser object

ccc7e5c

mdjermanovic approved these changes Aug 5, 2025

View reviewed changes

mdjermanovic moved this from Implementing to Second Review Needed in Triage Aug 5, 2025

harish-sethuraman approved these changes Aug 6, 2025

View reviewed changes

Tanujkanti4441 moved this from Second Review Needed to Merge Candidates in Triage Aug 6, 2025

snitin315 approved these changes Aug 7, 2025

View reviewed changes

snitin315 merged commit 699dbba into eslint:main Aug 7, 2025
37 checks passed

github-project-automation bot moved this from Merge Candidates to Complete in Triage Aug 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: playground crash due to ts parser #747

fix: playground crash due to ts parser #747

Uh oh!

Tanujkanti4441 commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jul 26, 2025 •

edited

Loading

Uh oh!

mdjermanovic left a comment

Uh oh!

mdjermanovic commented Jul 27, 2025 •

edited

Loading

Uh oh!

mdjermanovic commented Jul 28, 2025

Uh oh!

mdjermanovic left a comment

Uh oh!

harish-sethuraman left a comment

Uh oh!

nzakas commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

	...(options?.languageOptions?.parser ===
	"@typescript-eslint/parser" && {
	parser: typeScriptESLintParser,
	}),

Uh oh!

fix: playground crash due to ts parser #747

fix: playground crash due to ts parser #747

Uh oh!

Conversation

Tanujkanti4441 commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for new-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for es-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for zh-hans-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for fr-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for pt-br-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for ja-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for de-eslint ready!

Uh oh!

netlify bot commented Jul 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for hi-eslint ready!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdjermanovic commented Jul 28, 2025

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

harish-sethuraman left a comment

Choose a reason for hiding this comment

Uh oh!

nzakas commented Aug 6, 2025

Uh oh!

Uh oh!

Uh oh!

Tanujkanti4441 commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

netlify bot commented Jul 26, 2025 •

edited

Loading

mdjermanovic commented Jul 27, 2025 •

edited

Loading