Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/dialyzer/test: replace random:uniform/1 by rand:uniform/1 #9181

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

ariel-anieli
Copy link
Contributor

@ariel-anieli ariel-anieli commented Dec 11, 2024

Hello,

If this change makes sens, I'll push subsequent ones on the same modification:

git grep -Pn 'random:uniform' | \
    awk -F: '/lib\/dialyzer\/test/{ \
    cmd = sprintf("sed -i -e '%ds/random:uniform/rand:uniform/' %s\n", $2,$1); \
    system(cmd); \
    close(cmd)
    }'

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

CT Test Results

  2 files   42 suites   16m 25s ⏱️
477 tests 475 ✅ 2 💤 0 ❌
565 runs  563 ✅ 2 💤 0 ❌

Results for commit 7bf573c.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@ariel-anieli ariel-anieli changed the title lib/dialyzer/test/small_SUITE_data: replace random:uniform/1 by rand:uniform/1 lib/dialyzer/test: replace random:uniform/1 by rand:uniform/1 Dec 11, 2024
@lucioleKi lucioleKi self-assigned this Dec 12, 2024
@lucioleKi
Copy link
Contributor

Thank you for your contribution! I think this change is good. Since all the tests are in dialyzer, could you squash all of them into one commit?

```
$ git grep -Pn 'random:uniform' | \
    awk -F: '/lib\/dialyzer\/test/{ \
    cmd = sprintf("sed -i -e '%ds/random:uniform/rand:uniform/' %s\n", $2,$1); \
    system(cmd); \
    close(cmd)
    }'
```

Link: https://www.erlang.org/doc/deprecations.html#functions-deprecated-in-otp-19
Signed-off-by: Ariel Otilibili <[email protected]>
@ariel-anieli ariel-anieli force-pushed the random-deprec-lib-dialyzer branch from 9bb845c to 7bf573c Compare December 12, 2024 11:37
@ariel-anieli
Copy link
Contributor Author

Thank you for your contribution! I think this change is good. Since all the tests are in dialyzer, could you squash all of them into one commit?

Sure, @lucioleKi! Here is the sole commit.

@lucioleKi lucioleKi added team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI labels Dec 12, 2024
@lucioleKi lucioleKi self-requested a review December 16, 2024 09:39
@lucioleKi lucioleKi merged commit 9e1ba8b into erlang:master Dec 16, 2024
24 checks passed
@ariel-anieli ariel-anieli deleted the random-deprec-lib-dialyzer branch December 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants