Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/{mnesia,stdlib}: replace random functions by rand functions #9210

Merged
merged 1 commit into from
Jan 28, 2025
Merged

lib/{mnesia,stdlib}: replace random functions by rand functions #9210

merged 1 commit into from
Jan 28, 2025

Conversation

ariel-anieli
Copy link
Contributor

@ariel-anieli ariel-anieli commented Dec 17, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2024 •
edited
Loading

CT Test Results

  2 files   58 suites   19m 45s ⏱️
679 tests 531 ✅ 148 💤 0 ❌
733 runs  570 ✅ 163 💤 0 ❌

Results for commit 3c2fbb3.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Dec 19, 2024
@ariel-anieli
Copy link
Contributor Author

Hello; any news of the PR?

@Mikaka27
Copy link
Contributor

Hi, this is incomplete, there are still usages of random module in this file, could you fix those as well?

@IngelaAndin IngelaAndin added the waiting waiting for changes/input from author label Jan 21, 2025
@ariel-anieli
Copy link
Contributor Author

There you are, @Mikaka27; I have addressed your feedback.
Sorry for the late answer; I could only tackle this today.

@Mikaka27
Copy link
Contributor

Hi, this is still wrong, there is no rand:seed() function at all. You need to choose an algorithm, you can specify atom 'default' to the seed function.

@ariel-anieli
Copy link
Contributor Author

Hi, this is still wrong, there is no rand:seed() function at all. You need to choose an algorithm, you can specify atom 'default' to the seed function.

For me to understand your point; are we talking about rand:seed/0? The docs say it expects no argument.

The push force is for a rebase.

@ariel-anieli
Copy link
Contributor Author

My bad; this is rand:seed/1. The other was a type definition. I am push another commit.

@Mikaka27
Copy link
Contributor

Yes we need an argument, I think we can use 'default' atom there.

@ariel-anieli
lib/{mnesia,stdlib}: replace random functions by rand functions
3c2fbb3 
* follows from commit 7bf573c
* replacement is done everywhere, but in tests of `random` and `erl_lint`.

Signed-off-by: Ariel Otilibili <[email protected]>
@Mikaka27 Mikaka27 merged commit c8226a1 into erlang:master Jan 28, 2025
24 checks passed
@Mikaka27
Copy link
Contributor

Thanks for your contribution :)

@ariel-anieli ariel-anieli deleted the random-deprecated branch January 28, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikaka27 Mikaka27 Mikaka27 approved these changes

Assignees

@Mikaka27 Mikaka27

Labels
team:PS Assigned to OTP team PS waiting waiting for changes/input from author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariel-anieli @Mikaka27 @IngelaAndin