Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #536: Run After Create Database scripts are run even if database isn't created from scratch by grate #565

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

erikbra
Copy link
Owner

@erikbra erikbra commented Jul 23, 2024

Bug #536: Run After Create Database scripts are run even if database isn't created from scratch by grate

  • Wrote tests demonstrating the problem
  • Introduced "Key" in MigrationsFolder
  • Check on this to see if the folder is the "RunAfterCreateDatabase" folder

Fixes #536

@erikbra erikbra added the bug Something isn't working label Jul 23, 2024
@erikbra erikbra added this to the 1.8.0 milestone Jul 23, 2024
@erikbra erikbra self-assigned this Jul 23, 2024
@erikbra erikbra mentioned this pull request Jul 23, 2024
@erikbra erikbra force-pushed the bugs/536-runAfterCreateDatabase-is-always-run branch from 40becc7 to c44c0a8 Compare July 23, 2024 19:22
…isn't created from scratch by grate

* Wrote tests demonstrating the problem
* Introduced "Key" in MigrationsFolder
* Check on this to see if the folder is the "RunAfterCreateDatabase" folder
* Use Sql server on Ubuntu 22.04 for testing - the 20.04 one doesn't seem to work for CU14 (2024.07.23)
@erikbra erikbra force-pushed the bugs/536-runAfterCreateDatabase-is-always-run branch from eae9f4f to 37232a7 Compare July 23, 2024 20:50
@erikbra erikbra marked this pull request as ready for review July 23, 2024 21:03
@erikbra erikbra merged commit ae2d3db into main Jul 23, 2024
41 checks passed
@erikbra erikbra deleted the bugs/536-runAfterCreateDatabase-is-always-run branch July 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runAfterCreateDatabase are run even if database isn't created from scratch by grate
1 participant