Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove breaking spaces #554

Closed

Conversation

XelgoSett
Copy link

Hello, this is a possible solution to issue #536 :)

It looks like this may be a more general problem than just one folder name, and it requires a separate folder identifier and a user-friendly folder name. Please let me know if you would like me to prepare such changes.

But at the same time, Run After Create Database is a specific folder, and perhaps it can be fixed without major changes to the project. At least for now.

@XelgoSett XelgoSett marked this pull request as ready for review July 1, 2024 10:41
@erikbra
Copy link
Owner

erikbra commented Jul 23, 2024

Thanks a lot for your contribution, @XelgoSett . I see that I'm comparing apples and oranges here. As I mention in the linked issues, the folder confiuguration has become a bit messy, unfortunately. The whole configuration, and mess with knows folders, known folder names, and known folder keys should be re-written. They are. the result of the folder structure being fixed with RoundhousE, which I have inherited the start of grate from, and the folder configuration being fully dynamic in grate. I think I'd like to rewrite it a bit differently, and include a unit test to ensure that we know that the change works.

When fixing bugs, I usually start with writing a test that fails, to demonstrate the issue in a simple and easily reproducible way, and then implement the change, and see the test turning green. Then, I'm fairly sure that I have fixed the issue. And, all the other tests ensure (hopefully) that we haven't broken anything else

@erikbra
Copy link
Owner

erikbra commented Jul 23, 2024

Superceded by #565

@erikbra erikbra closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants