Size config rework (#3333) #4246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaButton: {
color: '#fff',
cssVariables: {
padding: '8px'
}
} |
|
preset="['secondary', 'small']" |
m0ksem
requested changes
May 3, 2024
| @@ -19,6 +20,7 @@ const packageJSON = JSON.parse(readFileSync(resolver(process.cwd(), './package.j | |||
| const dependencies = [...Object.keys(packageJSON.dependencies), ...Object.keys(packageJSON.peerDependencies)] | |||
|
|
|||
There was a problem hiding this comment.
Resolving @ import aliases didn't work for web components build build even though it was set up in tsconfig and other builds so I fixed it. But it turned out that other packages that import directly from ui/src fail to resolve @ so I guess using absolute imports is not supported at the moment
| export { defaultSizes as sizes, DefaultSizes as Sizes } from '../../composables' | ||
|
|
||
| export const variables = [ | ||
| 'position', |
There was a problem hiding this comment.
Position seems to be useless.
There was a problem hiding this comment.
It was in the variables that were defined so I added keys for all of the current variables.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3333
Description
Introduced sizes config with ability to override component CSS variables per size.
Types of changes