feat(VaButton): updated button size props to accept px values #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
reviewed
Apr 26, 2024
| const computedPxSizeStyle = computed(() => { | ||
| if (typeof props.size === 'number') { | ||
| return { | ||
| '--va-button-px-size': `${props.size}px`, |
There was a problem hiding this comment.
@Fsss126, please, review this logic and how it can be applied to sizes config.
There was a problem hiding this comment.
We have a size config refactoring in progress that would provide a more generalized way to solve cases like this one and make and desired customizations in-place #4246.
I would suggest releasing that one first and see if a need to pass px values would make sense to support then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4171
Markup:
Types of changes