Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificate_issuable.rb #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update certificate_issuable.rb #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/models/concerns/lets_encrypt/certificate_issuable.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ def csr

def create_certificate
order.finalize(csr: csr)
sleep 1 while order.status == 'processing'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to reload the order or wont work.
while order.status == 'processing'
sleep 1
order.reload
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to LetsEncrypt Ruby client...

fullchain = order.certificate.split("\n\n")
assign_new_certificate(fullchain)
save!
Expand Down