Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificate_issuable.rb #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kingtamil2001
Copy link

sleep with while condition holded the code flow in that paritcular line, so i removed it

@elct9620
Copy link
Owner

There is a condition to ensure the order is completed. I think we should not remove it directly.

@Kingtamil2001
Copy link
Author

Kingtamil2001 commented Dec 29, 2023

There is a condition to ensure the order is completed. I think we should not remove it directly.

but it block the flow in that line, if i removed this line its working fine

@elct9620
Copy link
Owner

There is a condition to ensure the order is completed. I think we should not remove it directly.

but it block the flow in that line, if i removed this line its working fine

In this case, we have to find the root cause blocking it.
For example, the Let's Encrypt API is changed to always return processing.

If we don't locate the root cause, the problem won't fixed.

@@ -26,7 +26,6 @@ def csr

def create_certificate
order.finalize(csr: csr)
sleep 1 while order.status == 'processing'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to reload the order or wont work.
while order.status == 'processing'
sleep 1
order.reload
end

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to LetsEncrypt Ruby client...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants