Fix error: comparison of unsigned expression < 0 is always false #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build all |
|
fyi @pshipton, can you review these changes? |
pshipton
approved these changes
Sep 6, 2024
|
jenkins build all |
keithc-ca
reviewed
Sep 6, 2024
omrthread_prio_t is of type uintptr_t. It cannot have a value below 0. J9THREAD_PRIORITY_MIN is defined as 0 and J9THREAD_PRIORITY_MAX is defined as 11. In omrthread_attr_set_priority, priority, which is of type omrthread_prio_t, will always be greater than or equal to J9THREAD_PRIORITY_MIN. To see if priority is invalid, we only need to evaluate if it is greater than J9THREAD_PRIORITY_MAX. Fixes: eclipse#7454 Signed-off-by: Babneet Singh <[email protected]>
keithc-ca
reviewed
Sep 9, 2024
|
jenkins build all |
keithc-ca
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omrthread_prio_tis of typeuintptr_t. It cannot have a value below 0.J9THREAD_PRIORITY_MINis defined as0andJ9THREAD_PRIORITY_MAXisdefined as
11.In
omrthread_attr_set_priority,priority, which is of typeomrthread_prio_t, will always be greater than or equal toJ9THREAD_PRIORITY_MIN. To see ifpriorityis invalid, we only needto evaluate if it is greater than
J9THREAD_PRIORITY_MAX.Fixes: #7454