Fix error: comparison of unsigned expression < 0 is always false

omrthread_prio_t is of type uintptr_t. It cannot have a value below 0. J9THREAD_PRIORITY_MIN is defined as 0 and J9THREAD_PRIORITY_MAX is defined as 11. In omrthread_attr_set_priority, priority, which is of type omrthread_prio_t, will always be greater than or equal to J9THREAD_PRIORITY_MIN. To see if priority is invalid, we only need to evaluate if it is greater than J9THREAD_PRIORITY_MAX. Fixes: #7454 Signed-off-by: Babneet Singh <[email protected]>
eclipse · Sep 9, 2024 · 9cd09f6 · 9cd09f6
1 parent 10fdf65
commit 9cd09f6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/thread/common/omrthreadattr.c b/thread/common/omrthreadattr.c
@@ -33,7 +33,6 @@
 #include "omrthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(omrthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t failedToSetAttr(intptr_t rc);
 
@@ -220,7 +219,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
  return J9THREAD_ERR_INVALID_ATTR;
  }
 
- if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+ if (priority > J9THREAD_PRIORITY_MAX) {
  return J9THREAD_ERR_INVALID_VALUE;
  }
 

diff --git a/thread/unix/omrthreadattr.c b/thread/unix/omrthreadattr.c
@@ -39,7 +39,6 @@
 #include "unix/unixthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t setStacksize(pthread_attr_t *pattr, uintptr_t stacksize);
 static intptr_t setPriority(pthread_attr_t *pattr, omrthread_prio_t priority);
@@ -288,7 +287,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
  return J9THREAD_SUCCESS;
  }
 
- if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+ if (priority > J9THREAD_PRIORITY_MAX) {
  return J9THREAD_ERR_INVALID_VALUE;
  }
 

diff --git a/thread/zos390/omrthreadattr.c b/thread/zos390/omrthreadattr.c
@@ -32,7 +32,6 @@
 #include "unix/unixthreadattr.h"
 
 #define J9THREAD_ATTR_IS_VALID(attr) ((attr) && (*(attr)) && ((*(attr))->size == sizeof(unixthread_attr)))
-#define J9THREAD_VALUE_OUT_OF_RANGE(val, lo, hi) (((val) < (lo)) || ((val) > (hi)))
 
 static intptr_t failedToSetAttr(intptr_t rc);
 
@@ -229,7 +228,7 @@ omrthread_attr_set_priority(omrthread_attr_t *attr, omrthread_prio_t priority)
  return J9THREAD_ERR_INVALID_ATTR;
  }
 
- if (J9THREAD_VALUE_OUT_OF_RANGE(priority, J9THREAD_PRIORITY_MIN, J9THREAD_PRIORITY_MAX)) {
+ if (priority > J9THREAD_PRIORITY_MAX) {
  return J9THREAD_ERR_INVALID_VALUE;
  }