Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to click actions to fail silently #3805

Merged
merged 6 commits into from
Jan 31, 2025
Merged

Add the ability to click actions to fail silently #3805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
18f3dae
Add the ability to click actions to fail silently
brianhall Jan 30, 2025
30af8ef
Fix linting
brianhall Jan 30, 2025
7c10ee7
Simplify the change
brianhall Jan 31, 2025
dc8fbc1
Remove errant reference
brianhall Jan 31, 2025
4672f78
Update tests
brianhall Jan 31, 2025
b88f2b3
Update tests...some more.
brianhall Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/PageElement.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ struct PageElement: Codable, Sendable {
let multiple: Bool?
let min: String?
let max: String?
let failSilently: Bool?
}

struct ProfileMatch: Codable, Sendable {
Expand Down
4 changes: 2 additions & 2 deletions ...DataBrokerProtection/Tests/DataBrokerProtectionTests/DataBrokerOperationActionTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ final class DataBrokerOperationActionTests: XCTestCase {
}

func testWhenActionNeedsEmail_thenExtractedProfileEmailIsSet() async {
let fillFormAction = FillFormAction(id: "1", actionType: .fillForm, selector: "#test", elements: [.init(type: "email", selector: "#email", parent: nil, multiple: nil, min: nil, max: nil)], dataSource: nil)
let fillFormAction = FillFormAction(id: "1", actionType: .fillForm, selector: "#test", elements: [.init(type: "email", selector: "#email", parent: nil, multiple: nil, min: nil, max: nil, failSilently: nil)], dataSource: nil)
let step = Step(type: .optOut, actions: [fillFormAction])
let sut = OptOutJob(
privacyConfig: PrivacyConfigurationManagingMock(),
Expand All @@ -152,7 +152,7 @@ final class DataBrokerOperationActionTests: XCTestCase {
}

func testWhenGetEmailServiceFails_thenOperationThrows() async {
let fillFormAction = FillFormAction(id: "1", actionType: .fillForm, selector: "#test", elements: [.init(type: "email", selector: "#email", parent: nil, multiple: nil, min: nil, max: nil)], dataSource: nil)
let fillFormAction = FillFormAction(id: "1", actionType: .fillForm, selector: "#test", elements: [.init(type: "email", selector: "#email", parent: nil, multiple: nil, min: nil, max: nil, failSilently: nil)], dataSource: nil)
let step = Step(type: .optOut, actions: [fillFormAction])
let sut = OptOutJob(
privacyConfig: PrivacyConfigurationManagingMock(),
Expand Down
Loading