Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to click actions to fail silently #3805

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

brianhall
Copy link
Collaborator

@brianhall brianhall commented Jan 30, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209274402556158/f
Tech Design URL:
CC:

Description:
Add a “failSilently” directive to click actions to allow them to fail without throwing an error.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Run tests
  2. Edit an existing broker JSON, changing the selector of a click action to something nonsensical, then run it and see the error pop up.
  3. No add failSilently to the element where you changed the selector and run it again. This action should not error out.

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@THISISDINOSAUR
Copy link
Contributor

I still get the error in debug mode, is that expected/am I doing something wrong?

Screenshot 2025-01-31 at 12 56 09 PM Screenshot 2025-01-31 at 12 56 02 PM

@brianhall
Copy link
Collaborator Author

Oh, so sorry. You’ll need to clone c-s-s using this branch (duckduckgo/content-scope-scripts#1444) then run npm i && npm run build, then drag it into XCode and try again.

Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brianhall brianhall merged commit 6f86fc6 into main Jan 31, 2025
21 checks passed
@brianhall brianhall deleted the bhall/support-click-actions-failing-silently branch January 31, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants