Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow click actions to fail silently with an additional parameter #1444

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

brianhall
Copy link
Contributor

@brianhall brianhall commented Jan 30, 2025

Asana Task/Github Issue: https://app.asana.com/0/608920331025329/1209274402556155/f

Description

Occasionally we need click actions to fail silently without throwing an error. A real life example: on https://www.privaterecords.net we need to click links on each record to expand the addresses / relatives to make matches most accurate, however sometimes these links won’t exist (for instance, if there are no results).

We don’t want to fail, because we want the extract action (with the noResultsFound directive) to run so we can mark a profile as “not found”.

Testing Steps

  • Integration tests
  • Drag/drop C-S-S into XCode

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 0740c65
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679e47b3f10691000875442f
😎 Deploy Preview https://deploy-preview-1444--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 30, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 30, 2025

[Beta] Generated file diff

Time updated: Sat, 01 Feb 2025 16:12:27 GMT

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

@brianhall brianhall marked this pull request as ready for review January 31, 2025 11:03
@brianhall brianhall requested review from shakyShane and a team as code owners January 31, 2025 11:03
@brianhall brianhall merged commit 8e1a55f into main Feb 1, 2025
12 checks passed
@brianhall brianhall deleted the bhall/allow-clicks-to-fail-silently branch February 1, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants