Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: customizer translations #1439

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 28, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209262697199928/f

Description

  • added translations for the customizer panel

Testing Steps

NOTE: There are some known styling issues, to be addressed in the next PR - merging this will help keep the sizes down (and will not be seen yet)

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane shakyShane marked this pull request as ready for review January 28, 2025 14:21
@shakyShane shakyShane requested review from mgurgel and a team as code owners January 28, 2025 14:21
@shakyShane
Copy link
Contributor Author

shakyShane commented Jan 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit fc0423f
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679bf9958797e70008b66814
😎 Deploy Preview https://deploy-preview-1439--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 28, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 28, 2025

[Beta] Generated file diff

Time updated: Thu, 30 Jan 2025 22:14:34 GMT

Integration
    - integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/de/new-tab.json
  • integration/pages/new-tab/locales/en/new-tab.json
  • integration/pages/new-tab/locales/es/new-tab.json
  • integration/pages/new-tab/locales/fr/new-tab.json
  • integration/pages/new-tab/locales/nl/new-tab.json
  • integration/pages/new-tab/locales/pl/new-tab.json
  • integration/pages/new-tab/locales/pt/new-tab.json
  • integration/pages/new-tab/locales/ru/new-tab.json

File has changed

Windows
    - windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/de/new-tab.json
  • windows/pages/new-tab/locales/en/new-tab.json
  • windows/pages/new-tab/locales/es/new-tab.json
  • windows/pages/new-tab/locales/fr/new-tab.json
  • windows/pages/new-tab/locales/nl/new-tab.json
  • windows/pages/new-tab/locales/pl/new-tab.json
  • windows/pages/new-tab/locales/pt/new-tab.json
  • windows/pages/new-tab/locales/ru/new-tab.json

File has changed

Apple
    - dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/de/new-tab.json
  • dist/pages/new-tab/locales/en/new-tab.json
  • dist/pages/new-tab/locales/es/new-tab.json
  • dist/pages/new-tab/locales/fr/new-tab.json
  • dist/pages/new-tab/locales/nl/new-tab.json
  • dist/pages/new-tab/locales/pl/new-tab.json
  • dist/pages/new-tab/locales/pt/new-tab.json
  • dist/pages/new-tab/locales/ru/new-tab.json

File has changed

@shakyShane shakyShane mentioned this pull request Jan 28, 2025
8 tasks
@shakyShane shakyShane force-pushed the 01-28-ntp_customizer_translations branch from abbaef8 to e0f0dc7 Compare January 29, 2025 18:28
@shakyShane shakyShane mentioned this pull request Jan 30, 2025
8 tasks
@shakyShane shakyShane force-pushed the 01-28-ntp_customizer_translations branch from e0f0dc7 to fc0423f Compare January 30, 2025 22:13
@shakyShane shakyShane merged commit c6b67bb into main Jan 31, 2025
14 checks passed
@shakyShane shakyShane deleted the 01-28-ntp_customizer_translations branch January 31, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants