Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: privacy stats ship review feedback #1406

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 17, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209181023494756/f

Description

  • don’t display the subtitle when there’s only ‘other’ companies
  • some general styling fixes

Testing Steps

  • We tested this over Zoom

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

github-actions bot commented Jan 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 17, 2025

[Beta] Generated file diff

Time updated: Fri, 17 Jan 2025 17:26:10 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js
  • integration/pages/new-tab/locales/en/new-tab.json

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js
  • windows/pages/new-tab/locales/en/new-tab.json

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js
  • dist/pages/new-tab/locales/en/new-tab.json

File has changed

@shakyShane shakyShane marked this pull request as ready for review January 17, 2025 14:39
@shakyShane shakyShane requested review from mgurgel and a team as code owners January 17, 2025 14:39
@shakyShane shakyShane force-pushed the 01-17-ntp_privacy_stats_ship_review_feedback branch from 1065b11 to 1e14179 Compare January 17, 2025 16:20
@shakyShane shakyShane force-pushed the 01-17-ntp_shipreview_changes_to_favorites branch from 92039ea to d9776ec Compare January 17, 2025 16:22
@shakyShane shakyShane force-pushed the 01-17-ntp_privacy_stats_ship_review_feedback branch from 1e14179 to c5aacaa Compare January 17, 2025 16:22
mgurgel
mgurgel previously approved these changes Jan 17, 2025
@shakyShane shakyShane force-pushed the 01-17-ntp_shipreview_changes_to_favorites branch from d9776ec to 1618d4a Compare January 17, 2025 16:42
@shakyShane shakyShane force-pushed the 01-17-ntp_privacy_stats_ship_review_feedback branch from c5aacaa to 9224242 Compare January 17, 2025 16:43
Base automatically changed from 01-17-ntp_shipreview_changes_to_favorites to main January 17, 2025 17:24
@shakyShane shakyShane dismissed mgurgel’s stale review January 17, 2025 17:24

The base branch was changed.

@shakyShane shakyShane force-pushed the 01-17-ntp_privacy_stats_ship_review_feedback branch from 9224242 to eea446a Compare January 17, 2025 17:25
Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit eea446a
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/678a927e0fdcbe000885cea6
😎 Deploy Preview https://deploy-preview-1406--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane merged commit 9635bd7 into main Jan 17, 2025
13 checks passed
@shakyShane shakyShane deleted the 01-17-ntp_privacy_stats_ship_review_feedback branch January 17, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants