ntp: shipreview changes to favorites #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 17, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 17 Jan 2025 16:43:50 GMT Integration
File has changed Windows
File has changed Apple
File has changed New Files
❌ File only exists in new changeset |
This was referenced Jan 17, 2025
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shakyShane
force-pushed
the
01-17-ntp_improved_background_fades
branch
from
c8330d5 to
99d11ef
Compare
shakyShane
force-pushed
the
01-17-ntp_shipreview_changes_to_favorites
branch
from
92039ea to
d9776ec
Compare
mgurgel
reviewed
Jan 17, 2025
| @@ -186,7 +186,27 @@ export function useItemState(url, id) { | |||
| }), | |||
| onDragStart: () => setState({ type: 'dragging' }), | |||
| onDrop: () => setState({ type: 'idle' }), | |||
| }), | |||
| onGenerateDragPreview: ({ nativeSetDragImage, source }) => { | |||
mgurgel
previously approved these changes
Jan 17, 2025
shakyShane
force-pushed
the
01-17-ntp_shipreview_changes_to_favorites
branch
from
d9776ec to
1618d4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue: https://app.asana.com/0/0/1209181023494752/f
Description
etldPlusOneso that the FE can control move of the derived values (like fallbacks)Testing Steps
Checklist
Please tick all that apply: