Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update broken svg-test #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/xml/svg-test.html
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@
console.log(el);

// EXTRAS: API for getting namespaced attribute values
console.log(NW.Dom.hasAttributeNS(el[0], 'xlink:href'));
console.log(NW.Dom.getAttributeNS(el[0], 'xlink:href'));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getAttributeNS doesn't seem to be implemented, sounds like a regression?

console.log(NW.Dom.Snapshot.hasAttributeNS(el[0], 'xlink:href'));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasAttributeNS is not available in Dom, but is available in Snapshot. Is that expected? This used to pass prior to 87fbfa9

};
</script>

Expand Down