update broken svg-test #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manvel
commented
Feb 13, 2024
| @@ -19,8 +19,7 @@ | |||
| console.log(el); | |||
|
|
|||
| // EXTRAS: API for getting namespaced attribute values | |||
| console.log(NW.Dom.hasAttributeNS(el[0], 'xlink:href')); | |||
| console.log(NW.Dom.getAttributeNS(el[0], 'xlink:href')); | |||
There was a problem hiding this comment.
getAttributeNS doesn't seem to be implemented, sounds like a regression?
Manvel
commented
Feb 13, 2024
| @@ -19,8 +19,7 @@ | |||
| console.log(el); | |||
|
|
|||
| // EXTRAS: API for getting namespaced attribute values | |||
| console.log(NW.Dom.hasAttributeNS(el[0], 'xlink:href')); | |||
| console.log(NW.Dom.getAttributeNS(el[0], 'xlink:href')); | |||
| console.log(NW.Dom.Snapshot.hasAttributeNS(el[0], 'xlink:href')); | |||
There was a problem hiding this comment.
hasAttributeNS is not available in Dom, but is available in Snapshot. Is that expected? This used to pass prior to 87fbfa9
|
@dperini feel free to close this, if the regression rather expected to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #101 (comment) the
test/xml/svg-test.htmlseem to be broken. Current PR updates the test. The tests seem to have been regressed since: 87fbfa9