Deduplicate IObjectNodeWithAlignment into shared Common dependency analysis#130325
Open
MichalStrehovsky with Copilot wants to merge 2 commits into
Open
Deduplicate IObjectNodeWithAlignment into shared Common dependency analysis#130325MichalStrehovsky with Copilot wants to merge 2 commits into
MichalStrehovsky with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: MichalStrehovsky <13110571+MichalStrehovsky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Deduplicate IObjectNodeWithAlignment files into Common directory
Deduplicate IObjectNodeWithAlignment into shared Common dependency analysis
Jul 8, 2026
jkotas
approved these changes
Jul 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates the IObjectNodeWithAlignment interface into the shared CoreCLR tooling “Common” dependency-analysis source set, removing the duplicated per-project definitions and keeping a single canonical contract for both ILCompiler tool projects.
Changes:
- Add shared
ILCompiler.DependencyAnalysis.IObjectNodeWithAlignmentundersrc/coreclr/tools/Common/Compiler/DependencyAnalysis/. - Update
ILCompiler.Compiler.csprojandILCompiler.ReadyToRun.csprojto compile/link the shared file. - Remove the ReadyToRun-local duplicate interface source entry (and delete the duplicate file).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/tools/Common/Compiler/DependencyAnalysis/IObjectNodeWithAlignment.cs | Adds the shared interface (and XML doc contract) in the common dependency-analysis namespace. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/ILCompiler.ReadyToRun.csproj | Links the shared interface file and removes the ReadyToRun-local compile item. |
| src/coreclr/tools/aot/ILCompiler.ReadyToRun/Compiler/DependencyAnalysis/ReadyToRun/IObjectNodeWithAlignment.cs | Deletes the ReadyToRun-local duplicate interface definition. |
| src/coreclr/tools/aot/ILCompiler.Compiler/ILCompiler.Compiler.csproj | Links the shared interface file and removes the project-local compile item. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the duplicate
IObjectNodeWithAlignmentdefinitions introduced after #129966 and restores a single shared contract for both AOT compiler projects.Shared interface
IObjectNodeWithAlignmenttosrc/coreclr/tools/Common/Compiler/DependencyAnalysis/IObjectNodeWithAlignment.csnamespace ILCompiler.DependencyAnalysis, matching the surrounding shared dependency-analysis surfaceGetAlignmentmust stay consistent withGetData/GetDehydratableDataProject file cleanup
ILCompiler.Compiler.csprojandILCompiler.ReadyToRun.csprojto compile the shared Common fileConsumer impact