[codex] Add writable INI configuration provider#128987
Draft
sharpninja wants to merge 2 commits into
Draft
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration |
rosebyte
requested changes
Jun 4, 2026
Member
rosebyte
left a comment
There was a problem hiding this comment.
@sharpninja, please create an issue with a proposal first as we need to get API approval before anything can be merged.
Author
|
@dotnet-policy-service agree |
Author
|
Created the requested API proposal issue: #128989 |
This was referenced Jun 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds writable INI support to
Microsoft.Extensions.Configuration.Iniwhile preserving the existing read-only provider behavior.The change introduces:
IniDocument, a lossless editable INI document model for section/key/value order and quote preservationWritableIniConfigurationSourceandWritableIniConfigurationProviderAddWritableIniFile(...)extension APIMotivation
The built-in INI provider can read files but cannot write changes back. This adds a writable provider for scenarios where applications need to read, modify, and save shared INI configuration without dropping unmanaged keys or changing quote style for existing values.
Validation
git diff --checkeng\common\dotnet.cmd build src\libraries\Microsoft.Extensions.Configuration.Ini\tests\Microsoft.Extensions.Configuration.Ini.Tests.csproj -c Debug -f net11.0 -v minimal /p:UseLocalTargetingRuntimePack=falseThe test assembly builds successfully. Direct local test execution is not included here because the runtime testhost was not built in this checkout;
build.cmd libs.pretest -c Debug -f net11.0 /p:UseLocalTargetingRuntimePack=falsestopped on the standard prerequisite that theCoreCLRsubset must be built first.