Validate Dns hostname for embedded null characters#128982
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Dns.GetHostEntry to validate for null characters
Validate Dns hostname for embedded null characters
Jun 4, 2026
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dns.GetHostEntryand friends forwarded hostnames containing\0to native resolvers (getaddrinfo/gethostbyname), which treat\0as end-of-string. The name was silently truncated and resolution failed in confusing ways instead of being rejected up front.Changes
Dns.ValidateHostName— added aContains('\0')check that throwsArgumentExceptionwith parameter namehostName. This is the single funnel reached from both the sync (GetHostEntryOrAddressesCore) and async (GetHostEntryOrAddressesCoreAsync) string code paths, so one check coversGetHostEntry,GetHostAddresses, theirAsync/Beginvariants, and the obsoleteGetHostByName/Resolveoverloads. IP-literal fast paths are unaffected (an IP literal cannot contain\0).Strings.resx— addednet_hostname_invalid_character("The host name cannot contain a null character.").GetHostEntryTest.cs— addedDnsGetHostEntry_NullCharacterInName_ThrowsArgumentExceptiontheory exercising leading/trailing/embedded null patterns against the sync and async entry points.