Skip to content

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Oct 14, 2025

New user_events support was added through #115265 that built upon existing eventpipe infrastructure, could emit both managed and native events as user_events (the old support could only emit native events), and unlike the old support, does not require the .NET app to be restarted nor ran with elevated permissions to emit user_events.

This PR removes the old support and removes the internal copy of LinuxTracePoints

Reverting #102523 led to merge conflicts that I resolved manually.

 git revert 7934e64
CONFLICT (content): Merge conflict in src/coreclr/dlls/mscoree/coreclr/CMakeLists.txt
CONFLICT (content): Merge conflict in src/coreclr/scripts/genEventing.py
CONFLICT (content): Merge conflict in src/coreclr/vm/eventing/CMakeLists.txt
CONFLICT (content): Merge conflict in src/native/external/cgmanifest.json

Reverting #104079 led to no merge conflicts

So as long as it's okay to completely revert those PRs, those conflicts were the only deviators.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 14, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the old user_events support and the internal copy of LinuxTracepoints. The old support required elevated permissions and app restarts to emit user_events, while the new support added in PR #115265 uses the existing eventpipe infrastructure and can emit both managed and native events without these limitations.

Key changes:

  • Complete removal of the internal LinuxTracepoints library copy
  • Elimination of old user_events infrastructure that required elevated permissions
  • Cleanup of build system references to the removed components

Reviewed Changes

Copilot reviewed 88 out of 129 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/native/external/LinuxTracepoints-version.txt Removes version tracking file for the deleted LinuxTracepoints copy
src/native/external/LinuxTracepoints/libtracepoint-decode-cpp/include/tracepoint/*.h Removes header files for the tracepoint decode library
src/native/external/LinuxTracepoints/libtracepoint-decode-cpp/README.md Removes documentation for the decode library
src/native/external/LinuxTracepoints/libtracepoint-decode-cpp/CMakeLists.txt Removes build configuration for the decode library
src/native/external/LinuxTracepoints/libtracepoint-control-cpp/tools/tracepoint-collect.cpp Removes command-line tool for collecting tracepoints
src/native/external/LinuxTracepoints/libtracepoint-control-cpp/src/*.cpp Removes implementation files for tracepoint control functionality
src/native/external/LinuxTracepoints/libtracepoint-control-cpp/samples/*.cpp Removes sample code demonstrating library usage
src/native/external/LinuxTracepoints/libtracepoint-control-cpp/include/tracepoint/*.h Removes header files for the control library
src/native/external/LinuxTracepoints/libtracepoint-control-cpp/CMakeLists.txt Removes build configuration for the control library
src/native/external/LinuxTracepoints/libeventheader-tracepoint/src/*.c Removes EventHeader tracepoint implementation
src/native/external/LinuxTracepoints/libeventheader-tracepoint/samples/*.cpp Removes EventHeader sample applications
src/native/external/LinuxTracepoints/libeventheader-tracepoint/include/eventheader/*.h Removes EventHeader header files
src/native/external/LinuxTracepoints/libeventheader-tracepoint/CMakeLists.txt Removes build configuration for EventHeader library
src/native/external/LinuxTracepoints/libeventheader-decode-cpp/tools/decode-perf.cpp Removes perf data decoding tool
src/native/external/LinuxTracepoints/libeventheader-decode-cpp/src/*.cpp Removes EventHeader decode implementation
src/native/external/LinuxTracepoints/libeventheader-decode-cpp/samples/CMakeLists.txt Removes build configuration for decode samples

@mdh1418
Copy link
Member Author

mdh1418 commented Oct 14, 2025

Added folks that had taken a look at the PR that added the old support.

@@ -1,9 +1,3 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the license header?

@jkotas
Copy link
Member

jkotas commented Oct 15, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants