Add test for runtime async and update linker handling of method body #120683
+137
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-Tools-ILLink
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for runtime async methods in the linker's dataflow analysis and test infrastructure. It fixes an issue where the linker would incorrectly validate IL for runtime async methods that return Task but don't have a value on the stack for the ret instruction.
Key changes:
- Adds test infrastructure support for
/featuresand/nowarncompiler arguments - Creates comprehensive test cases for runtime async methods with various dataflow scenarios
- Updates method body scanner to handle runtime async methods correctly
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| TestCaseCompiler.cs | Adds support for /features and /nowarn compiler arguments in test compilation |
| RuntimeAsyncMethods.cs | New test file with comprehensive coverage of runtime async method dataflow scenarios |
| MethodDefinitionExtensions.cs | Adds IsRuntimeAsync() extension method to detect runtime async methods |
| MethodBodyScanner.cs | Updates IL validation logic to handle runtime async methods that don't have return values on stack |
| features.Add(feature[..featureSplit], feature[(featureSplit + 1)..]); | ||
| break; | ||
| } | ||
| else if(splitIndex != -1 && option[..splitIndex] == "/nowarn") |
There was a problem hiding this comment.
Missing space after 'if' keyword. Should be 'else if (' to maintain consistent formatting with the rest of the codebase.
Suggested change
| else if(splitIndex != -1 && option[..splitIndex] == "/nowarn") | |
| else if (splitIndex != -1 && option[..splitIndex] == "/nowarn") |
Copilot uses AI. Check for mistakes.
dotnet-policy-service
bot
added
the
linkable-framework
|
Tagging subscribers to this area: @dotnet/illink |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120340
Adds test with some rutnime async methods, and fixes the check for invalid IL when a Task returning async method doesn't have a value on the stack for
ret.