Skip to content

arm64: Optimise x < 0 and x >= 0 #120667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

arm64: Optimise x < 0 and x >= 0 #120667

wants to merge 3 commits into from

Conversation

jonathandavies-arm
Copy link
Contributor

@jonathandavies-arm
arm64: Optimise x < 0 and x >= 0
dc4e0bb 
- Fixes dotnet#83562
- Add tests for previous work
- Add tbz/tbnz support for short and sbyte
@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 13, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 13, 2025
@build-analysis build-analysis bot mentioned this pull request Oct 13, 2025
Open
@am11
Copy link
Member

am11 commented Oct 14, 2025

cc @tomeksowi, in case this opt is interesting for riscv64. :)

jakobbotsch
jakobbotsch reviewed Oct 14, 2025
View reviewed changes
src/coreclr/jit/lower.cpp Outdated
Comment on lines 4566 to 4572
LIR::Use use;
op1Type = cast->gtCastType;
GenTree* castOp = cast->CastOp();
BlockRange().TryGetUse(cast, &use);
use.ReplaceWith(castOp);
BlockRange().Remove(cast);
relopOp1 = castOp;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
LIR::Use use;
op1Type = cast->gtCastType;
GenTree* castOp = cast->CastOp();
BlockRange().TryGetUse(cast, &use);
use.ReplaceWith(castOp);
BlockRange().Remove(cast);
relopOp1 = castOp;
op1Type = cast->gtCastType;
GenTree* castOp = cast->CastOp();
cond->AsOp()->gtOp1 = castOp;
BlockRange().Remove(cast);
relopOp1 = castOp;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

This was referenced Oct 14, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ARM64 - Follow-up on x < 0 and x >= 0

3 participants

@jonathandavies-arm @am11 @jakobbotsch