-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Helper Method Frames (HMF) from Reflection #109996
Open
AaronRobinsonMSFT
wants to merge
7
commits into
dotnet:main
Choose a base branch
from
AaronRobinsonMSFT:hmf_remove05
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+179
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @mangod9 |
@EgorBot -intel -arm64 -perf
|
AaronRobinsonMSFT
requested review from
steveisok and
vitek-karas
as code owners
November 20, 2024 01:29
@EgorBot -x64 -arm64 -profiler using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
public class Bench
{
struct S;
[Benchmark]
public Type Nested() => typeof(S).DeclaringType;
[Benchmark]
public Type NotNested() => typeof(Bench).DeclaringType;
[Benchmark]
public Type RefElementType() => typeof(Bench[]).GetElementType();
[Benchmark]
public Type ValueElementType() => typeof(S[]).GetElementType();
} |
@AaronRobinsonMSFT the bot complained that |
@EgorBot -x64 -arm64 using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
public class Bench
{
struct S;
[Benchmark]
public Type Nested() => typeof(S).DeclaringType;
[Benchmark]
public Type NotNested() => typeof(Bench).DeclaringType;
[Benchmark]
public Type RefElementType() => typeof(Bench[]).GetElementType();
[Benchmark]
public Type ValueElementType() => typeof(S[]).GetElementType();
} |
This was referenced Nov 20, 2024
@EgorBot -x64 -arm64 -profiler using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Running;
public class Bench
{
struct S;
[Benchmark]
public Type RefElementType() => typeof(Bench[]).GetElementType();
[Benchmark]
public Type ValueElementType() => typeof(S[]).GetElementType();
} |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert
RuntimeMethodHandle.GetDeclaringType()
to managed and QCall.Convert
RuntimeTypeHandle.GetElementType()
to managed.Correct nullability in signature and usage.
Convert
RuntimeTypeHandle.GetDeclaringType()
to managed and QCalls.Remove
GetRuntimeTypeHelper()
.