-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for newlines in email address. #102311
Conversation
This adds validation for embedded newlines in email addresses. There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior
Tagging subscribers to this area: @dotnet/ncl |
...omponentModel.Annotations/src/System/ComponentModel/DataAnnotations/EmailAddressAttribute.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Mail/src/System/Net/Mail/MailAddress.cs
Outdated
Show resolved
Hide resolved
Do we want to keep the switches around at all given this is vNext? |
Co-authored-by: Miha Zupan <[email protected]>
cc @wfurt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we can go either way. I somewhat agree that valid scenario with CRLF is unrealistic but I don't mind the comp switch either. |
* Check for newlines in email address. This adds validation for embedded newlines in email addresses. There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior * Apply suggestions from code review Co-authored-by: Miha Zupan <[email protected]> * Remove compat switch --------- Co-authored-by: Tomas Weinfurt <[email protected]> Co-authored-by: Miha Zupan <[email protected]>
This adds validation for embedded newlines in email addresses.
There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior.