Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for newlines in email address. #102311

Merged
merged 3 commits into from
May 20, 2024
Merged

Check for newlines in email address. #102311

merged 3 commits into from
May 20, 2024

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented May 16, 2024

This adds validation for embedded newlines in email addresses.
There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior.

This adds validation for embedded newlines in email addresses.
There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior
Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@rzikm rzikm requested a review from a team May 16, 2024 08:48
@MihaZupan
Copy link
Member

Do we want to keep the switches around at all given this is vNext?
I doubt there's real scenarios for it.

@rzikm
Copy link
Member Author

rzikm commented May 16, 2024

cc @wfurt

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wfurt
Copy link
Member

wfurt commented May 16, 2024

Do we want to keep the switches around at all given this is vNext?
I doubt there's real scenarios for it.

I think we can go either way. I somewhat agree that valid scenario with CRLF is unrealistic but I don't mind the comp switch either.

@rzikm rzikm merged commit 8fcadc6 into dotnet:main May 20, 2024
81 of 83 checks passed
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
* Check for newlines in email address.

This adds validation for embedded newlines in email addresses.
There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior

* Apply suggestions from code review

Co-authored-by: Miha Zupan <[email protected]>

* Remove compat switch

---------

Co-authored-by: Tomas Weinfurt <[email protected]>
Co-authored-by: Miha Zupan <[email protected]>
@karelz karelz added this to the 9.0.0 milestone Jun 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants