Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ROR(x, 32) on arm64 #102291

Merged
merged 3 commits into from
May 16, 2024
Merged

Fix ROR(x, 32) on arm64 #102291

merged 3 commits into from
May 16, 2024

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented May 15, 2024

Fixes #102285

Minimal repro:

static bool Test(long x) => 
    long.RotateLeft(x, 32) == 3886722753596608508;

the previous logic folded GT_ROR(x, 32) to GT_ROR(x, 0) because it took parentNode (which is (int)GT_EQ) into account to calculate max rotation width.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label May 15, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member Author

EgorBo commented May 15, 2024

/azp run runtime-coreclr jitstress-random

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EgorBo
Copy link
Member Author

EgorBo commented May 15, 2024

PTAL @dotnet/jit-contrib trivial fix

@EgorBo EgorBo merged commit 7ac4c51 into dotnet:main May 16, 2024
107 checks passed
@EgorBo EgorBo deleted the fix-ror-arm64 branch May 16, 2024 10:22
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull request May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime_86027 test fails in jitstress-random
3 participants