ILLink: Check for all expected warnings, then fail if any are unmatched #102286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
linkable-framework
jtschuster
added
area-Tools-ILLink
dotnet-policy-service
bot
added
linkable-framework
|
Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas |
jtschuster
commented
May 23, 2024
| @@ -14,9 +16,9 @@ public TrimmingTestLogger () | |||
| MessageContainers = new List<MessageContainer> (); | |||
| } | |||
|
|
|||
| public List<MessageContainer> GetLoggedMessages () | |||
| public ImmutableArray<MessageContainer> GetLoggedMessages () | |||
There was a problem hiding this comment.
To make sure we don't modify the message list outside of the logger, we should return an immutable array.
sbomer
approved these changes
May 23, 2024
Ruihan-Yin
pushed a commit
to Ruihan-Yin/runtime
that referenced
this pull request
May 30, 2024
…ed (dotnet#102286) In Linker tests, we fail at the first ExpectedWarning that isn't matched, and print all the messages that haven't been matched yet, even though they may match another ExpectedWarning that just hasn't been processed yet. Instead, we should keep a list of all expected warnings that were missing report them at once along with all unmatched warnings. This makes it much easier to debug when a test is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Linker tests, we fail at the first ExpectedWarning that isn't matched, and print all the messages that haven't been matched yet, even though they may match another ExpectedWarning that just hasn't been processed yet.
Instead, we should keep a list of all expected warnings that were missing report them at once along with all unmatched warnings. This makes it much easier to debug when a test is failing.