Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_page_content retrieved non page-content objects from the toolbar #423

Merged
merged 4 commits into from
Sep 22, 2024

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 20, 2024

Description

cms_toolbars.VersioningPageToolbar.get_page_content also retrieved non-page content toolbar objects. Fixes #425

Related resources

Checklist

  • I have opened this pull request against master
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on
    Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun marked this pull request as ready for review September 22, 2024 10:09
@fsbraun fsbraun requested a review from a team September 22, 2024 10:09
@fsbraun fsbraun merged commit 07222a4 into master Sep 22, 2024
107 of 109 checks passed
@fsbraun fsbraun deleted the fix/get-page-content branch September 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Versioned custom models fail with AttributeError on missing in_navigation property
2 participants