Some bugfixes to incorporate #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`djangocms_blog/includes/blog_item.html` expects a `postcontent` variable instead of `post_content`.
This is a workaround as the CMS expects such an attribute, but I have no idea under what conditions it has to be set to True or False. Maybe the MENU_TYPE of the Blog AppConfig? I tried both True and False without any noticeable difference (at least while keeping `BlogConfig.menu_structure` set to `MENU_TYPE_COMPLETE`).
This is necessary as GrouperModelAdmin instances are required to include the extra grouping fields in their fieldsets.
fsbraun
reviewed
Aug 23, 2024
|
Hey @GaretJax ! Thanks a lot!! With the exception, of the |
|
Mainly because it was raising an exception without :-D I will have to try and see if it still happens if I remove that code again, and report back with more details. This will take some time however, I'm far from my computer for a couple of weeks. |
|
If it still raises an exception without |
fsbraun
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using your branch on CMS v4 and I have encountered some issues that I have
fixedworked around with the following changes.It is meant to serve as inspiration/bug report, so feel free to rework and make yours.