Skip to content

fix(DHIS2-19863): expose code field in ApiToken #21435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

kabaros
Copy link
Contributor

@kabaros kabaros commented Jul 17, 2025

implements https://dhis2.atlassian.net/browse/DHIS2-19863

When exposing the code field for ApiToken in the UI, we realised that it is ignored by the API. This is because generatePersonalAccessToken creates a new instance of ApiToken that uses the builder, and omits the BaseIdentifiable params.

We've looked at making the method more generic so that it supports other base fields (like name for example), but then realised that only code is part of the ApiToken schema, so opted for just adding that one field to the builder.

@kabaros kabaros requested a review from netroms July 17, 2025 11:33
@kabaros kabaros added the deploy Deploy DHIS2 instance with IM. label Jul 17, 2025
Copy link

@jason-p-pickering jason-p-pickering merged commit 8c00705 into master Jul 18, 2025
19 checks passed
@jason-p-pickering jason-p-pickering deleted the DHIS2-19863/expose-apitoken-code branch July 18, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy DHIS2 instance with IM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants