fix(DHIS2-19863): expose code field in ApiToken #21435
Merged
+23
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements https://dhis2.atlassian.net/browse/DHIS2-19863
When exposing the
code
field forApiToken
in the UI, we realised that it is ignored by the API. This is becausegeneratePersonalAccessToken
creates a new instance ofApiToken
that uses the builder, and omits theBaseIdentifiable
params.We've looked at making the method more generic so that it supports other base fields (like
name
for example), but then realised that onlycode
is part of theApiToken
schema, so opted for just adding that one field to the builder.