-
Notifications
You must be signed in to change notification settings - Fork 12
fix(DHIS2-19863): introduced code field in api tokens #1495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
implements: https://dhis2.atlassian.net/browse/DHIS2-19863 This implementation adds a code field in the PAT generation form and a code display in the token list card. This is to allow the uset to be able to label their tokens depending on how they are used
implements: https://dhis2.atlassian.net/browse/DHIS2-19863 This implementation adds a code field in the PAT generation form and a code display in the token list card. This is to allow the user to be able to label their tokens depending on how they are used
…nto DHIS2-19863/expose-code-field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
implements: https://dhis2.atlassian.net/browse/DHIS2-19863 Added error handling that displays to the user the message `Token name already exists` whenever they try to generate new API token with a code that already exists in the system. I had to display that custom message instead of the default error report message because the report message refers to the field as `code` field but we had changed the field name to `Token name` This error handling implementation also includes handling of 409 coded errors to display the error report messages instead of the general import summary error.
implements: https://dhis2.atlassian.net/browse/DHIS2-19863 Added error handling that displays to the user the message `Token name already exists` whenever they try to generate new API token with a code that already exists in the system. I had to display that custom message instead of the default error report message because the report message refers to the field as `code` field but we had changed the field name to `Token name` This error handling implementation also includes handling of 409 coded errors to display the error report messages instead of the general import summary error. The implemenation also includes addition of a helpText on the Token name code explaining what the field is for.
…nto DHIS2-19863/expose-code-field
I added error handling that displays to the user the message This error handling implementation also includes handling of 409 coded errors to display the error report messages instead of the general import summary error. The implemenation also includes addition of a helpText on the Token name code explaining what the field is for. |
Applied proper formatting by running `yarn format`
Added the API token display on a newly created API token. Also fixed the label on the existing API token display
|
implements: https://dhis2.atlassian.net/browse/DHIS2-19863
This implementation adds a code field to the PAT generation form and a code display in the token list card, allowing users to label their tokens according to their intended use.
Note: This implementation requires This pull request
Screenshots: