-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Add support for preact x #48
Open
cristianbote
wants to merge
14
commits into
developit:master
Choose a base branch
from
cristianbote:chore/add-support-for-preact-x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4698fa8
(chore) Add support for preact x
cristianbote 3eb2369
Added dependecies and revert not needed changes
cristianbote a41d029
Remove compatibility note
cristianbote 3377c1d
Bumped the preact version
cristianbote 223af0b
Add the lock changes
cristianbote d3689eb
Switched to latest react-redux
cristianbote d68e191
Exclude the preact/compat
cristianbote 7e5cb57
Apply suggestions from code review
cristianbote f41535d
Plucked methods rather than full compat
cristianbote 8c1a872
Update compat imports
cristianbote fa12ce3
Import everything from /compat
cristianbote 3babf09
(chore) Added the note about long time support
cristianbote ec4441b
(chore) Remove LTS note
cristianbote 8eef81f
(chore) Adjust the preact version
cristianbote File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,49 @@ | ||
export { Component, Component as PureComponent } from "preact"; | ||
import { createContext } from "preact-context"; | ||
import { h } from "preact"; | ||
import empty from "./empty"; | ||
import { | ||
createContext, | ||
createElement, | ||
Component, | ||
useEffect, | ||
useContext, | ||
useMemo, | ||
useLayoutEffect, | ||
useRef, | ||
useReducer, | ||
memo, | ||
forwardRef, | ||
PureComponent, | ||
unstable_batchedUpdates | ||
} from 'preact/compat'; | ||
|
||
export default { | ||
const React = { | ||
Component, | ||
PureComponent, | ||
createContext, | ||
forwardRef: empty, | ||
createElement: h | ||
createElement, | ||
useEffect, | ||
useContext, | ||
useMemo, | ||
useLayoutEffect, | ||
useRef, | ||
useReducer, | ||
forwardRef, | ||
memo, | ||
unstable_batchedUpdates | ||
}; | ||
|
||
export { | ||
Component, | ||
PureComponent, | ||
createContext, | ||
createElement, | ||
useEffect, | ||
useContext, | ||
useMemo, | ||
useLayoutEffect, | ||
useRef, | ||
useReducer, | ||
forwardRef, | ||
memo, | ||
unstable_batchedUpdates | ||
}; | ||
|
||
export default React; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
import { Provider, connect, connectAdvanced, ReactReduxContext } from 'react-redux'; | ||
export { Provider, connect, connectAdvanced, ReactReduxContext }; | ||
export default { Provider, connect, connectAdvanced, ReactReduxContext }; | ||
import * as ReactRedux from 'react-redux'; | ||
export * from 'react-redux'; | ||
|
||
export default ReactRedux; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including preact/compat completely defeats the purpose of this project, doesn't it? 😿