(chore) Add support for preact x #48
Conversation
|
This will fail until preactjs/preact#1901 is merged |
|
This is gonna be working when preactjs/preact#1924 it's gonna get released |
|
Also this updates the |
|
Folks will be glad to have this working in X. One question still in my mind though: do we know why aliasing |
Awesome pointers! Co-Authored-By: Jason Miller <[email protected]>
|
Hey @developit that's a great point! Unfortunately it seems that the build size increases if I would add the imports by hand and re-export them. 🤷♂ |
|
@cristianbote @marvinhagemeister Any ideas on when this might be released? Would really like to upgrade to Preact X. Many thanks |
|
@jhdevuk it's awaiting Jason's review. It's on his todo list 👍 |
| @@ -11,7 +11,7 @@ const babelRc = JSON.parse(fs.readFileSync(".babelrc")); | |||
| let pkg = JSON.parse(fs.readFileSync("./package.json")); | |||
|
|
|||
| let external = Object.keys(pkg.peerDependencies || {}).concat( | |||
| Object.keys(pkg.dependencies || {}) | |||
| Object.keys(pkg.dependencies || {}), 'preact/compat' | |||
There was a problem hiding this comment.
Including preact/compat completely defeats the purpose of this project, doesn't it? 😿
|
Ok, well, what are the alternatives? Where to get |
This adds support for
preact xbut depends on this PR frompreactpreactjs/preact#1901. After that's merged and released we could merge this one as well.Adds+3.71kB😞 more than double it's current sizeAdds+0.89kB😄 now we're talkingAdds
+0.98kB🤔