Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add golangci-lint fixer #4853

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add golangci-lint fixer #4853

merged 1 commit into from
Nov 27, 2024

Conversation

sigmavirus24
Copy link
Contributor

Closes #4616

@sigmavirus24 sigmavirus24 marked this pull request as ready for review November 24, 2024 12:31
@sigmavirus24 sigmavirus24 mentioned this pull request Nov 24, 2024
Closed
hsanson
hsanson requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a failing test.

autoload/ale/fixers/golangci_lint.vim Outdated Show resolved Hide resolved
test/fixers/test_golangci_lint_fixer_callback.vader Outdated Show resolved Hide resolved
hsanson
hsanson approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@hsanson hsanson merged commit 65b49c1 into dense-analysis:master Nov 27, 2024
7 checks passed
@sigmavirus24
Copy link
Contributor Author

Thanks for accepting this and helping work through it. This is my first vim plug-in contribution ever

@sigmavirus24 sigmavirus24 deleted the bug/4616 branch November 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsanson hsanson hsanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fixer for golangci-lint
2 participants
@sigmavirus24 @hsanson