Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixer for golangci-lint #4616

Closed
davidjb opened this issue Sep 25, 2023 · 2 comments · Fixed by #4853
Closed

Add fixer for golangci-lint #4616

davidjb opened this issue Sep 25, 2023 · 2 comments · Fixed by #4853
Assignees
Labels
new tool Support for new linters, fixers, etc.

Comments

@davidjb
Copy link

davidjb commented Sep 25, 2023

Name: golangci-lint
URL: https://github.com/golangci/golangci-lint

This was previously reported at #2864:

GoLangCI-lint has a fixer now: golangci-lint run --fix ./...

The ALE fixer will have the same issues we're having with the ALE linter.

This original issue was to add a fixer for golangci-lint and there may have been some confusion as the issue was closed on account of golangci-lint as a linter already existing.

As best I can tell and from what I've tried, golangci-lint isn't available as a fixer (e.g. it's not visible in :ALEFixSuggest nor has a file listed at https://github.com/dense-analysis/ale/tree/master/autoload/ale/fixers or visible elsewhere in the codebase).

@davidjb davidjb added the new tool Support for new linters, fixers, etc. label Sep 25, 2023
@w0rp w0rp self-assigned this Nov 20, 2023
@sigmavirus24
Copy link
Contributor

@w0rp if there are some docs on how to contribute this easily, I'd be happy to give it a shot. I also think I'm seeing that there's no way to configure goimports with a local prefix.

sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 3, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 15, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 16, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 16, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 17, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 23, 2024
sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 24, 2024
@sigmavirus24
Copy link
Contributor

I think #4853 fixes this. It's my first vim plugin contribution but as far as I can tell, it's passing tests.

sigmavirus24 added a commit to sigmavirus24/ale that referenced this issue Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new tool Support for new linters, fixers, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants