Bugfix/nlurkin #19
Open
Bugfix/nlurkin #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlurkin
commented
Mar 16, 2020
nlurkin
commented
- Update README with requirements and tested versions of external libraries
- Fix printing of TDCHit (leading and trailing type measurements were switched)
- Fix trigger offset helper function (not only the last byte must be filled with ones, but one must use two's complement
added 3 commits
March 14, 2020 16:53
The printing inverted the meaning of the leading/trailing bit.
Not only the last byte needs to be filled with 1 in case of negative number, but "therefore the sign bit must be extended to the full word in order to avoid mistakes" (V1190 documentation). one's complement + 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.