Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/nlurkin #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix/nlurkin #19

wants to merge 3 commits into from

Conversation

nlurkin
Copy link

@nlurkin nlurkin commented Mar 16, 2020

  • Update README with requirements and tested versions of external libraries
  • Fix printing of TDCHit (leading and trailing type measurements were switched)
  • Fix trigger offset helper function (not only the last byte must be filled with ones, but one must use two's complement

Nicolas Lurkin added 3 commits March 14, 2020 16:53
Update README with requirements
42e487e
Fix printing of TDCHit.
8731d52 
The printing inverted the meaning of the leading/trailing bit.
Fix trigger offset helper function
a26dd62 
Not only the last byte needs to be filled with 1 in case of negative
number, but "therefore the sign bit must be extended to the full word in
order to avoid mistakes" (V1190 documentation).
one's complement + 1
@swertz swertz mentioned this pull request Jan 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nlurkin