Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for CentOS7, tweaks to CMake script #20

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

swertz
Copy link

@swertz swertz commented Jan 26, 2022

Note: I've realized there is some overlap with #19 - if that is merged first I can rebase.

Addresses #18 , although I did not encounter some of the issues mentioned there (forcing compiler version, linking to pthread, ... because of different devtoolset or cmake version?).

  • Remove build folder to let cmake handle it and make it possible to transparently rm -r build to start a clean build
  • Bump cmake version - I've chosen 3.11 which is reasonably new; even centOS7 EPEL has 3.17 anyway.
  • Make some changes in cmake to "modern" cmake style, but some is still "old" style
  • README: add requirements and instructions for centOS7 - some of the cmake changes were required to build there (e.g. adding -ldl), I hope that didn't break the builds on modern systems...

@swertz
Copy link
Author

swertz commented Feb 9, 2022

Updated with a bugfix in CommonDef.h:: CAENVME_API does not name a type, most likely what was meant was CVErrorCodes...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant