Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline set of fixes for release #10052

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

Baseline set of fixes for release #10052

wants to merge 64 commits into from

Commits on Jul 30, 2023

  1. Fix ndarray compilation

    Fix left over test issue
    Add hack that configures surefire to use a wrapper that allows us to debug tests
    agibsonccc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    77aabe9 View commit details
    Browse the repository at this point in the history
  2. Fix ndarray compilation

    Fix left over test issue
    Add hack that configures surefire to use a wrapper that allows us to debug tests
    agibsonccc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    40cac19 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Add new build scripts

    Fix up deallocation race conditions with constants (removes random deallocation of constants)
    
    Bring back some deallocations
    agibsonccc committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    0f780b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Add deallocation and allocation logging behind a flag to allow better…

    … debugging of stack traces
    
    when SD_GCC_FUNCTRACE is turned on and the right environment is set.
    Remove old dependencies from tests
    agibsonccc committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    9865169 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2023

  1. Fix up transpose op bugs. (deallocations and shape buffer related)

    Ensure thread safety on deallocations in pointerwrapper,opaquebuffer
    Fix up uniform dealocation and result propagation.
    Remove commented code.
    Remove old traceNew method
    Removes old clionide exclusion in type_boilerplate.h
    Remove unused scalar.cu
    Misc fixes for scalar related shape descriptor creation
    Update java build script
    Remove some unused c++ tests
    Improve debug statements in DeclarableOp.cpp
    Add new FuncTracce developer doc explaining the functionality.
    agibsonccc committed Aug 13, 2023
    Configuration menu
    Copy the full SHA
    b3abfdc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Clean up string assign support

    More deleted code
    agibsonccc committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    569337c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Add proper thread sanitizer support

    Add flag on environment to enable/disable delete special/primary buffers
    Misc unused code cleanup
    agibsonccc committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3b2ada2 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Configuration menu
    Copy the full SHA
    9269620 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. WIP:

    Empty flags fixes across various ops
    Various flag fixes for each op
    agibsonccc committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8aa0ef1 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Fix dynamic stitch in cuda

    Remove various empty specific workarounds across different ops
    agibsonccc committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    0b96de1 View commit details
    Browse the repository at this point in the history
  2. Fix conv2d cuda invocation

    agibsonccc committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    836f51f View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Fix cpu build

    agibsonccc committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2a9cd46 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2023

  1. Add new result set printing

    Fix up solve for cuda
    agibsonccc committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    749ed8d View commit details
    Browse the repository at this point in the history
  2. Remove print statements

    Add lup dimensions
    agibsonccc committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    949e7f8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Add databuffer debugging

    Add databuffer print for cuda/cpu
    agibsonccc committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    44746f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Remove print statements

    Add softmax launch dimensions
    Fix view write bug with assign and cast
    agibsonccc committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0ddaf46 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Fix underlyng tad cuda issue

    Fix softmax
    agibsonccc committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    967fb47 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Configuration menu
    Copy the full SHA
    a33c200 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Fix array options data type

    Add validation for data type creation
    agibsonccc committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    09d3cfc View commit details
    Browse the repository at this point in the history
  2. Fix array options data type

    Add validation for data type creation
    agibsonccc committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    8da6147 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e89c928 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Add partitioned tensorflow tests to alleviate cuda resource constraints

    Add ending statement to printIndexedBuffer for easier searching when large arrays are output
    Remove im2col/col2im configurations in testing scripts
    agibsonccc committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    abf2bfa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1248eb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Fix range shape return type

    Fix bool data types
    agibsonccc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    87ea11e View commit details
    Browse the repository at this point in the history
  2. Fix up more range invocations and empty shapes

    Fix squeeze and slice empty shapes
    agibsonccc committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d4419b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Fix all TF partitions

    Port cumsum cpu implementation over to cuda as temp workaround
    Fix broadcast_bool edge cases.
    agibsonccc committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d4df0a1 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Add more order validation.

    Remove prints statements
    Automatically return c on 0 rank arrays
    agibsonccc committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7923dc8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06f0e06 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Add reshape to flattened params

    Misc formatting
    Fix up rest of cuda tests
    Add more cuda validation to  various kernel launches
    agibsonccc committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    7e092ae View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2023

  1. Fix misc reshape issues with 2d biases

    Consolidate reflection based classloading for deserialization
    and op loading
    Remove more legacy helper related code
    Fix various databuffer deallocations
    Refactor related DifferentialFunctionClassHolder usage
    Fix conv1d related undefined behavior/process hangs when a bias is null
    agibsonccc committed Dec 3, 2023
    Configuration menu
    Copy the full SHA
    86e5975 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2023

  1. Fix assign on flatten arrays

    Reshape would have issues when the array can't be returned as a view.
    Incorrect arrays would be created. This affected parameters among other things.
    Create new linear_copy to ensure we can bypass calculate output shape with assign and non broadcastable arrays.
    agibsonccc committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    eb39721 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Overhaul workspaces usage in deeplearning4j-nn.

    Removes random scope borrow/exit. Changes it to a standardized
    input and output workspace enter/exit.
    agibsonccc committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    9dc5bff View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b57454 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    fa037f2 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Add model manager in python in dl4j contrib.

    Add java side model manager for baseline interop and testing.
    agibsonccc committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    7e162fa View commit details
    Browse the repository at this point in the history
  2. Add first bidirectional test

    Fix minor model manager issues with computing gradients.
    agibsonccc committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    650007a View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Fix model manager running models

    Fix bidirectional import in keras
    agibsonccc committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    2ecd289 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Finish fixing recurrent layer

    Finish adding abstractions for the keras model tests
    Add concrete implementation based on hand coded test of bidirectional.
    Add "well known directory" for keras save_models that java and python use.
    Add commented implementation of a base class for tests that use these modules.
    Rename things to be clearly tied to keras to avoid confusion with existing samediff tensorflow import tests
    agibsonccc committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    ec28aca View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2024

  1. Add new ndarray logging to track changes to arrays over time.

    Adds array registry for tracking arrays in a central location mapped by id.
    Adds event instrumentation to different parts of the nd4j api to track data at different parts of an array's lifecyle.
    agibsonccc committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    3538c99 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix bidirectional tests

    agibsonccc committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    891dbe6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    864caa5 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    4f195a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Fix lstm gradient check tests

    Fix view offset detection by omitting views from element wise stride based offset calculations.
    agibsonccc committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    ca78a4b View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Fix up shape.h linking

    Add new check input change which detects when an op changes an input and throws an exception when this is the case.
    agibsonccc committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    0d467ea View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2024

  1. Add c++ based log ndarray events (print statements in ndarray and dat…

    …abuffer) to detect subtle move/copy bugs
    agibsonccc committed Mar 16, 2024
    Configuration menu
    Copy the full SHA
    f24a437 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Fix subtle view issues

    Add explicit destructor for ndarrays
    Improve logging for ndarray constructors with separate environment variable
    agibsonccc committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    17e85ae View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Fix simplernn gemm

    agibsonccc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    f2ecc7b View commit details
    Browse the repository at this point in the history
  2. Add missing function

    agibsonccc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    7d0920e View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Fix conv3d gradient checks

    agibsonccc committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    f26dfa6 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Configuration menu
    Copy the full SHA
    a5bf886 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Rewrite locallyconnected 2d.

    Update address sanitizer build to link correctly.
    Revert op.z() caching due to eager mode.
    Remove VEDA/VEDNN
    Convert all smart pointer databuffers to normal pointers.
    Due to external buffers they produce very inconnsistent results.
    agibsonccc committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    837b3e2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    127f7e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Configuration menu
    Copy the full SHA
    5ac76d0 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Fix conv2d gradient checks (ports java logic to c++)

    Rewrites conv2d to delegate to c++ while keeping the same logic.
    agibsonccc committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    fe86569 View commit details
    Browse the repository at this point in the history
  2. Remove print statements

    Fix bias conv2d gradient
    agibsonccc committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    1ba16b3 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Fix nchw setting in conv2d.

    Fix sizes for locally connected 2d.
    agibsonccc committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6887d2b View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Clean up print statements

    Fix NHWC case for new conv2d invocation.
    agibsonccc committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    07b7e07 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Add creation stack trace tracking for constructors

    when functrace is turned on.
    Fix delete in constant shape helper when a shape descirptor exists.
    agibsonccc committed May 2, 2024
    Configuration menu
    Copy the full SHA
    d32edbf View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Fix batched gemm indexing.

    Delete more aurora
    agibsonccc committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ae93deb View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Fix constant shape helper with reshape in place.

    Add validation for cache values that are being stored.
    agibsonccc committed May 6, 2024
    Configuration menu
    Copy the full SHA
    3a1db4c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0b300c6 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    dffcc13 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Configuration menu
    Copy the full SHA
    0bc7237 View commit details
    Browse the repository at this point in the history
  2. Get rid of tests.

    agibsonccc committed May 15, 2024
    Configuration menu
    Copy the full SHA
    dc108a7 View commit details
    Browse the repository at this point in the history