Baseline set of fixes for release #10052
Open
+60,195
−53,432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix left over test issue Add hack that configures surefire to use a wrapper that allows us to debug tests
Fix left over test issue Add hack that configures surefire to use a wrapper that allows us to debug tests
Fix up deallocation race conditions with constants (removes random deallocation of constants) Bring back some deallocations
… debugging of stack traces when SD_GCC_FUNCTRACE is turned on and the right environment is set. Remove old dependencies from tests
Ensure thread safety on deallocations in pointerwrapper,opaquebuffer Fix up uniform dealocation and result propagation. Remove commented code. Remove old traceNew method Removes old clionide exclusion in type_boilerplate.h Remove unused scalar.cu Misc fixes for scalar related shape descriptor creation Update java build script Remove some unused c++ tests Improve debug statements in DeclarableOp.cpp Add new FuncTracce developer doc explaining the functionality.
More deleted code
Add flag on environment to enable/disable delete special/primary buffers Misc unused code cleanup
Remove various empty specific workarounds across different ops
Fix up solve for cuda
Add lup dimensions
Add databuffer print for cuda/cpu
Add softmax launch dimensions Fix view write bug with assign and cast
Fix softmax
Add validation for data type creation
Add validation for data type creation
Add ending statement to printIndexedBuffer for easier searching when large arrays are output Remove im2col/col2im configurations in testing scripts
Fix bool data types
Fix squeeze and slice empty shapes
Port cumsum cpu implementation over to cuda as temp workaround Fix broadcast_bool edge cases.
Remove prints statements Automatically return c on 0 rank arrays
Misc formatting Fix up rest of cuda tests Add more cuda validation to various kernel launches
Consolidate reflection based classloading for deserialization and op loading Remove more legacy helper related code Fix various databuffer deallocations Refactor related DifferentialFunctionClassHolder usage Fix conv1d related undefined behavior/process hangs when a bias is null
Kali-Zoidberg
approved these changes
Jan 11, 2024
|
This is mega PR :-) |
archenroot
approved these changes
Jan 11, 2024
|
Thanks for checking folks! I'll be breaking this up in the next week or so |
Adds array registry for tracking arrays in a central location mapped by id. Adds event instrumentation to different parts of the nd4j api to track data at different parts of an array's lifecyle.
Fix view offset detection by omitting views from element wise stride based offset calculations.
Add new check input change which detects when an op changes an input and throws an exception when this is the case.
…abuffer) to detect subtle move/copy bugs
Add explicit destructor for ndarrays Improve logging for ndarray constructors with separate environment variable
Update address sanitizer build to link correctly. Revert op.z() caching due to eager mode. Remove VEDA/VEDNN Convert all smart pointer databuffers to normal pointers. Due to external buffers they produce very inconnsistent results.
Rewrites conv2d to delegate to c++ while keeping the same logic.
Fix bias conv2d gradient
Fix sizes for locally connected 2d.
Fix NHWC case for new conv2d invocation.
when functrace is turned on. Fix delete in constant shape helper when a shape descirptor exists.
Delete more aurora
Add validation for cache values that are being stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
Quick checklist
The following checklist helps ensure your PR is complete: